linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion
@ 2020-04-09  9:24 Oliver Graute
  2020-04-09 10:14 ` Dan Carpenter
  2020-04-09 10:15 ` Dan Carpenter
  0 siblings, 2 replies; 6+ messages in thread
From: Oliver Graute @ 2020-04-09  9:24 UTC (permalink / raw)
  To: gregkh
  Cc: oliver.graute, Oliver Graute, dri-devel, linux-fbdev, devel,
	linux-kernel

From: Oliver Graute <oliver.graute@kococonnector.com>

Enable inversion mode

Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
---
 drivers/staging/fbtft/fb_st7789v.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c
index 3c3f387936e8..84c5af2dc9a0 100644
--- a/drivers/staging/fbtft/fb_st7789v.c
+++ b/drivers/staging/fbtft/fb_st7789v.c
@@ -120,6 +120,10 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, PWCTRL1, 0xA4, 0xA1);
 
 	write_reg(par, MIPI_DCS_SET_DISPLAY_ON);
+
+	/* enable inversion mode */
+	write_reg(par, 0x21);
+
 	return 0;
 }
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion
  2020-04-09  9:24 [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion Oliver Graute
@ 2020-04-09 10:14 ` Dan Carpenter
  2020-04-27  8:31   ` Oliver Graute
  2020-04-09 10:15 ` Dan Carpenter
  1 sibling, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2020-04-09 10:14 UTC (permalink / raw)
  To: Oliver Graute
  Cc: gregkh, devel, linux-fbdev, Oliver Graute, linux-kernel, dri-devel

On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote:
> From: Oliver Graute <oliver.graute@kococonnector.com>
> 
> Enable inversion mode
> 
> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> ---
>  drivers/staging/fbtft/fb_st7789v.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c
> index 3c3f387936e8..84c5af2dc9a0 100644
> --- a/drivers/staging/fbtft/fb_st7789v.c
> +++ b/drivers/staging/fbtft/fb_st7789v.c
> @@ -120,6 +120,10 @@ static int init_display(struct fbtft_par *par)
>  	write_reg(par, PWCTRL1, 0xA4, 0xA1);
>  
>  	write_reg(par, MIPI_DCS_SET_DISPLAY_ON);
> +
> +	/* enable inversion mode */
> +	write_reg(par, 0x21);

Use the define and delete the comment.

	write_reg(par, MIPI_DCS_ENTER_INVERT_MODE);

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion
  2020-04-09  9:24 [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion Oliver Graute
  2020-04-09 10:14 ` Dan Carpenter
@ 2020-04-09 10:15 ` Dan Carpenter
  2020-04-27  8:29   ` Oliver Graute
  1 sibling, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2020-04-09 10:15 UTC (permalink / raw)
  To: Oliver Graute
  Cc: gregkh, devel, linux-fbdev, Oliver Graute, linux-kernel, dri-devel

On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote:
> From: Oliver Graute <oliver.graute@kococonnector.com>
> 
> Enable inversion mode

What the heck is an inversion mode and why would you want it?

regards,
dasn carpenter


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion
  2020-04-09 10:15 ` Dan Carpenter
@ 2020-04-27  8:29   ` Oliver Graute
  2020-04-28 18:58     ` Dan Carpenter
  0 siblings, 1 reply; 6+ messages in thread
From: Oliver Graute @ 2020-04-27  8:29 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: gregkh, devel, linux-fbdev, Oliver Graute, linux-kernel, dri-devel

On 09/04/20, Dan Carpenter wrote:
> On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote:
> > From: Oliver Graute <oliver.graute@kococonnector.com>
> > 
> > Enable inversion mode
> 
> What the heck is an inversion mode and why would you want it?


Should I name it:

Enable MIPI_DCS_ENTER_INVERT_MODE

Best Regards,

Oliver

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion
  2020-04-09 10:14 ` Dan Carpenter
@ 2020-04-27  8:31   ` Oliver Graute
  0 siblings, 0 replies; 6+ messages in thread
From: Oliver Graute @ 2020-04-27  8:31 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: gregkh, devel, linux-fbdev, Oliver Graute, linux-kernel, dri-devel

On 09/04/20, Dan Carpenter wrote:
> On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote:
> > From: Oliver Graute <oliver.graute@kococonnector.com>
> > 
> > Enable inversion mode
> > 
> > Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> > ---
> >  drivers/staging/fbtft/fb_st7789v.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c
> > index 3c3f387936e8..84c5af2dc9a0 100644
> > --- a/drivers/staging/fbtft/fb_st7789v.c
> > +++ b/drivers/staging/fbtft/fb_st7789v.c
> > @@ -120,6 +120,10 @@ static int init_display(struct fbtft_par *par)
> >  	write_reg(par, PWCTRL1, 0xA4, 0xA1);
> >  
> >  	write_reg(par, MIPI_DCS_SET_DISPLAY_ON);
> > +
> > +	/* enable inversion mode */
> > +	write_reg(par, 0x21);
> 
> Use the define and delete the comment.
> 
> 	write_reg(par, MIPI_DCS_ENTER_INVERT_MODE);

ok, I'll do on next version

Best regards,

Oliver

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion
  2020-04-27  8:29   ` Oliver Graute
@ 2020-04-28 18:58     ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2020-04-28 18:58 UTC (permalink / raw)
  To: Oliver Graute
  Cc: devel, linux-fbdev, gregkh, Oliver Graute, linux-kernel, dri-devel

On Mon, Apr 27, 2020 at 10:29:39AM +0200, Oliver Graute wrote:
> On 09/04/20, Dan Carpenter wrote:
> > On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote:
> > > From: Oliver Graute <oliver.graute@kococonnector.com>
> > > 
> > > Enable inversion mode
> > 
> > What the heck is an inversion mode and why would you want it?
> 
> 
> Should I name it:
> 
> Enable MIPI_DCS_ENTER_INVERT_MODE
> 

What I'm saying is the changelog should explain why would want to apply
the patch.  What does the inversion mode do?  Is it inverting the color
or flipping something upside down?

Probably if I had a background in graphics I would know what "Enable
inversion mode" means...  But three words is not a proper and complete
commit message normally.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-04-28 19:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-09  9:24 [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion Oliver Graute
2020-04-09 10:14 ` Dan Carpenter
2020-04-27  8:31   ` Oliver Graute
2020-04-09 10:15 ` Dan Carpenter
2020-04-27  8:29   ` Oliver Graute
2020-04-28 18:58     ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).