* [PATCH RESEND] hwmon: (k10temp) make some symbols static
@ 2020-04-09 8:45 Jason Yan
2020-04-09 15:58 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-09 8:45 UTC (permalink / raw)
To: clemens, jdelvare, linux, linux-hwmon, linux-kernel; +Cc: Jason Yan
Fix the following sparse warning:
drivers/hwmon/k10temp.c:189:12: warning: symbol 'k10temp_temp_label' was
not declared. Should it be static?
drivers/hwmon/k10temp.c:202:12: warning: symbol 'k10temp_in_label' was
not declared. Should it be static?
drivers/hwmon/k10temp.c:207:12: warning: symbol 'k10temp_curr_label' was
not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/hwmon/k10temp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index 3f37d5d81fe4..9915578533bb 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -186,7 +186,7 @@ static long get_raw_temp(struct k10temp_data *data)
return temp;
}
-const char *k10temp_temp_label[] = {
+static const char *k10temp_temp_label[] = {
"Tctl",
"Tdie",
"Tccd1",
@@ -199,12 +199,12 @@ const char *k10temp_temp_label[] = {
"Tccd8",
};
-const char *k10temp_in_label[] = {
+static const char *k10temp_in_label[] = {
"Vcore",
"Vsoc",
};
-const char *k10temp_curr_label[] = {
+static const char *k10temp_curr_label[] = {
"Icore",
"Isoc",
};
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] hwmon: (k10temp) make some symbols static
2020-04-09 8:45 [PATCH RESEND] hwmon: (k10temp) make some symbols static Jason Yan
@ 2020-04-09 15:58 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-04-09 15:58 UTC (permalink / raw)
To: Jason Yan; +Cc: clemens, jdelvare, linux-hwmon, linux-kernel
On Thu, Apr 09, 2020 at 04:45:02PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
>
> drivers/hwmon/k10temp.c:189:12: warning: symbol 'k10temp_temp_label' was
> not declared. Should it be static?
> drivers/hwmon/k10temp.c:202:12: warning: symbol 'k10temp_in_label' was
> not declared. Should it be static?
> drivers/hwmon/k10temp.c:207:12: warning: symbol 'k10temp_curr_label' was
> not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-09 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-09 8:45 [PATCH RESEND] hwmon: (k10temp) make some symbols static Jason Yan
2020-04-09 15:58 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).