From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rui.zhang@intel.com
Cc: amit.kucheria@verdurent.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org (open list:THERMAL)
Subject: [PATCH 5/6] thermal: core: Move the call to thermal_cdev_udpate() to the power allocator
Date: Sat, 11 Apr 2020 00:12:34 +0200 [thread overview]
Message-ID: <20200410221236.6484-6-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20200410221236.6484-1-daniel.lezcano@linaro.org>
All the calls to the thermal_cdev_update() are in the governors except
one in the power_actor_set_power(). Move the update right after the
call to power_actor_set_power(), the function will be located in the
IPA governor.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/power_allocator.c | 2 ++
drivers/thermal/thermal_core.c | 1 -
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/power_allocator.c b/drivers/thermal/power_allocator.c
index fd7c8de02250..339442925dfe 100644
--- a/drivers/thermal/power_allocator.c
+++ b/drivers/thermal/power_allocator.c
@@ -433,6 +433,8 @@ static int allocate_power(struct thermal_zone_device *tz,
total_granted_power += granted_power[i];
+ thermal_cdev_update(instance->cdev);
+
i++;
}
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 052f77b0b0ef..a6b8c0240656 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -614,7 +614,6 @@ int power_actor_set_power(struct thermal_cooling_device *cdev,
return ret;
instance->target = state;
- thermal_cdev_update(cdev);
return 0;
}
--
2.17.1
next prev parent reply other threads:[~2020-04-10 22:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 22:12 [PATCH 0/6] Consolidate the thermal_cdev_update() function Daniel Lezcano
2020-04-10 22:12 ` [PATCH 1/6] thermal: hwmon: Replace the call the thermal_cdev_update() Daniel Lezcano
2020-04-11 1:32 ` Guenter Roeck
2020-04-11 16:45 ` Daniel Lezcano
2020-04-11 17:26 ` Guenter Roeck
2020-04-11 21:07 ` Daniel Lezcano
2020-04-10 22:12 ` [PATCH 2/6] thermal: core: Move thermal_cdev_update next to updated=false Daniel Lezcano
2020-04-10 22:12 ` [PATCH 3/6] thermal: core: Remove pointless 'updated' boolean Daniel Lezcano
2020-04-10 22:12 ` [PATCH 4/6] thermal: power_allocator: Remove useless test Daniel Lezcano
2020-04-10 22:12 ` Daniel Lezcano [this message]
2020-04-10 22:12 ` [PATCH 6/6] thermal: core: Make thermal_cdev_update private Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410221236.6484-6-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).