linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: syzbot <syzbot+77fa5bdb65cc39711820@syzkaller.appspotmail.com>
Cc: darrick.wong@oracle.com, hch@infradead.org, jack@suse.cz,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-xfs@vger.kernel.org, riteshh@linux.ibm.com,
	syzkaller-bugs@googlegroups.com, tytso@mit.edu
Subject: Re: WARNING in iomap_apply
Date: Sat, 11 Apr 2020 09:14:39 -0700	[thread overview]
Message-ID: <20200411161439.GE21484@bombadil.infradead.org> (raw)
In-Reply-To: <00000000000048518b05a2fef23a@google.com>

On Sat, Apr 11, 2020 at 12:39:13AM -0700, syzbot wrote:
> The bug was bisected to:
> 
> commit d3b6f23f71670007817a5d59f3fbafab2b794e8c
> Author: Ritesh Harjani <riteshh@linux.ibm.com>
> Date:   Fri Feb 28 09:26:58 2020 +0000
> 
>     ext4: move ext4_fiemap to use iomap framework
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=16c62a57e00000
> final crash:    https://syzkaller.appspot.com/x/report.txt?x=15c62a57e00000
> console output: https://syzkaller.appspot.com/x/log.txt?x=11c62a57e00000
> 
> IMPORTANT: if you fix the bug, please add the following tag to the commit:
> Reported-by: syzbot+77fa5bdb65cc39711820@syzkaller.appspotmail.com
> Fixes: d3b6f23f7167 ("ext4: move ext4_fiemap to use iomap framework")
> 
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 7023 at fs/iomap/apply.c:51 iomap_apply+0xa0c/0xcb0 fs/iomap/apply.c:51

This is:

        if (WARN_ON(iomap.length == 0))
                return -EIO;

and the call trace contains ext4_fiemap() so the syzbot bisection looks
correct.

>  iomap_fiemap+0x184/0x2c0 fs/iomap/fiemap.c:88
>  _ext4_fiemap+0x178/0x4f0 fs/ext4/extents.c:4860
>  ovl_fiemap+0x13f/0x200 fs/overlayfs/inode.c:467
>  ioctl_fiemap fs/ioctl.c:226 [inline]
>  do_vfs_ioctl+0x8d7/0x12d0 fs/ioctl.c:715

  reply	other threads:[~2020-04-11 16:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-11  7:39 WARNING in iomap_apply syzbot
2020-04-11 16:14 ` Matthew Wilcox [this message]
2020-04-12  9:17   ` Ritesh Harjani
2020-04-12  9:40     ` Amir Goldstein
2020-04-12  9:24 ` [RFC 1/1] ext4: Fix overflow case for map.m_len in ext4_iomap_begin_* Ritesh Harjani
2020-04-14 15:50   ` Jan Kara
2020-04-16  7:38     ` Ritesh Harjani
     [not found] ` <20200411092558.20856-1-hdanton@sina.com>
2020-04-12 16:12   ` WARNING in iomap_apply Darrick J. Wong
     [not found] <0000000000007beadf05a36790eb@google.com>
2020-04-16 14:58 ` Ritesh Harjani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200411161439.GE21484@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=darrick.wong@oracle.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=riteshh@linux.ibm.com \
    --cc=syzbot+77fa5bdb65cc39711820@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).