From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B05DC2BB86 for ; Sat, 11 Apr 2020 23:39:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BC17206A1 for ; Sat, 11 Apr 2020 23:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586648362; bh=rxTEkZE/qzuNHsnmwj0H4/iT7J3HTtkntHYrbIhjhRc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=sRap9SwC2n1A9ncXqVsH31EVPr60xG5TsYgpHhfLiAowOWccxtMlF+BoV4qSyUea1 F9vw5AB5h1ySdboglFuH3ZUwEQSfTKD/Vf5Bu48gjEhFcm0xXZmW8bPC/OEWbM0b5V KKXhgqjB/09HyUzBv0nD4AMlzmKHtB8L9pV0ejx8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730732AbgDKXjU (ORCPT ); Sat, 11 Apr 2020 19:39:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:43790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728164AbgDKXHk (ORCPT ); Sat, 11 Apr 2020 19:07:40 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3EB862173E; Sat, 11 Apr 2020 23:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646461; bh=rxTEkZE/qzuNHsnmwj0H4/iT7J3HTtkntHYrbIhjhRc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gERVlpJgEcsp127ZqHGt9rL3S5LwxGsn7pM5+A+0DM5Ym6pisgXF6i6xk4SHjzhPi g61kzewwVP/4JctR+YGVdWHgeEhp8tG2IuWUON7Ot/a8+FdxgF+BWU/yJfnDt79Fa3 AKtwFuqM0p6W7VAg2xUizYYP6ilKdMBL+bf5fUB4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vlad Buslov , Roi Dayan , Sasha Levin , netdev@vger.kernel.org, linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 5.5 029/121] net/mlx5e: Init ethtool steering for representors Date: Sat, 11 Apr 2020 19:05:34 -0400 Message-Id: <20200411230706.23855-29-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200411230706.23855-1-sashal@kernel.org> References: <20200411230706.23855-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vlad Buslov [ Upstream commit 6783e8b29f636383af293a55336f036bc7ad5619 ] During transition to uplink representors the code responsible for initializing ethtool steering functionality wasn't added to representor init rx routine. This causes NULL pointer dereference during configuration of network flow classification rule with ethtool (only possible to reproduce with next commit in this series which registers necessary ethtool callbacks). Signed-off-by: Vlad Buslov Reviewed-by: Roi Dayan Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c index f175cb24bb671..62c3a2e884912 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c @@ -1630,6 +1630,8 @@ static int mlx5e_init_rep_rx(struct mlx5e_priv *priv) if (err) goto err_destroy_ttc_table; + mlx5e_ethtool_init_steering(priv); + return 0; err_destroy_ttc_table: -- 2.20.1