From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E65CC2BBC7 for ; Sat, 11 Apr 2020 23:13:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0841020787 for ; Sat, 11 Apr 2020 23:13:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646792; bh=IvlAPJhpYEn2ikijRvMCZL3uzCia8LH0darRJog/0FA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1eupSGPI4EvAz0NxglKFVMZB+odyorYw2NMijhDEtSRCXuv1oPhqS8AfdmwKjvH0E jEg1ZFkZw1KVAJwuVY7YFHuo8GCpr6003jPB/Od9dxZX5GiI5kGh0prQ1Q37ukWWUF NiYfbqHhF0CuOBjWjtCXa2tHnri4bYpEuqsCNt80= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730354AbgDKXNK (ORCPT ); Sat, 11 Apr 2020 19:13:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:53528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730272AbgDKXMy (ORCPT ); Sat, 11 Apr 2020 19:12:54 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D5DA21835; Sat, 11 Apr 2020 23:12:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646774; bh=IvlAPJhpYEn2ikijRvMCZL3uzCia8LH0darRJog/0FA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gE2+f3FyaKfWUHyNItEXT2w0miSCkLaULwWmc0qtImKmNvX68TWogngKNz62Qrrnc hI9H2jSQNp93n7Jcbo0Y9VYM5sEM8cMLk+6xvLTMz6o9WLc6G6T8Cf7wG0wEf4Zb0j yIgrdEXdx1c3MyXVjoXbJus0GO7mgrmNI7GCf6lk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Qiujun Huang , syzbot+4496e82090657320efc6@syzkaller.appspotmail.com, Hillf Danton , Marcel Holtmann , Sasha Levin , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 41/66] Bluetooth: RFCOMM: fix ODEBUG bug in rfcomm_dev_ioctl Date: Sat, 11 Apr 2020 19:11:38 -0400 Message-Id: <20200411231203.25933-41-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200411231203.25933-1-sashal@kernel.org> References: <20200411231203.25933-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiujun Huang [ Upstream commit 71811cac8532b2387b3414f7cd8fe9e497482864 ] Needn't call 'rfcomm_dlc_put' here, because 'rfcomm_dlc_exists' didn't increase dlc->refcnt. Reported-by: syzbot+4496e82090657320efc6@syzkaller.appspotmail.com Signed-off-by: Qiujun Huang Suggested-by: Hillf Danton Signed-off-by: Marcel Holtmann Signed-off-by: Sasha Levin --- net/bluetooth/rfcomm/tty.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/bluetooth/rfcomm/tty.c b/net/bluetooth/rfcomm/tty.c index 5e44d842cc5d0..cf0ccd05329c7 100644 --- a/net/bluetooth/rfcomm/tty.c +++ b/net/bluetooth/rfcomm/tty.c @@ -413,10 +413,8 @@ static int __rfcomm_create_dev(struct sock *sk, void __user *arg) dlc = rfcomm_dlc_exists(&req.src, &req.dst, req.channel); if (IS_ERR(dlc)) return PTR_ERR(dlc); - else if (dlc) { - rfcomm_dlc_put(dlc); + if (dlc) return -EBUSY; - } dlc = rfcomm_dlc_alloc(GFP_KERNEL); if (!dlc) return -ENOMEM; -- 2.20.1