From: Orson Zhai <orson.unisoc@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Jason Baron <jbaron@akamai.com>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
orsonzhai@gmail.com, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, kernel-team@android.com,
Orson Zhai <orson.zhai@unisoc.com>
Subject: Re: [PATCH] dynamic_debug: Add an option to enable dynamic debug for modules only
Date: Mon, 13 Apr 2020 13:02:42 +0800 [thread overview]
Message-ID: <20200413050241.GA5694@lenovo> (raw)
In-Reply-To: <20200410124414.GB2091460@kroah.com>
On Fri, Apr 10, 2020 at 02:44:14PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 10, 2020 at 08:33:04PM +0800, Orson Zhai wrote:
> > From: Orson Zhai <orson.zhai@unisoc.com>
> >
> > Instead of enabling dynamic debug globally with CONFIG_DYNAMIC_DEBUG,
> > CONFIG_DYNAMIC_DEBUG_CORE will only enable core function of dynamic
> > debug. With the DEBUG_MODULE defined for any modules, dynamic debug
> > will be tied to them.
> >
> > This is useful for people who only want to enable dynamic debug for
> > kernel modules without worrying about kernel image size and memory
> > consumption is increasing too much.
> >
> > Signed-off-by: Orson Zhai <orson.zhai@unisoc.com>
> > ---
> > Documentation/admin-guide/dynamic-debug-howto.rst | 7 +++++--
> > include/linux/dev_printk.h | 6 ++++--
> > include/linux/dynamic_debug.h | 2 +-
> > include/linux/printk.h | 14 +++++++++-----
> > lib/Kconfig.debug | 12 ++++++++++++
> > lib/Makefile | 2 +-
> > lib/dynamic_debug.c | 9 +++++++--
> > 7 files changed, 39 insertions(+), 13 deletions(-)
>
> Crazy idea, I like it :)
Jason was highly appreciated for his suggestion to my RFC patch before this.
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thank you very much.
Best,
Orson
next prev parent reply other threads:[~2020-04-13 5:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 12:33 [PATCH] dynamic_debug: Add an option to enable dynamic debug for modules only Orson Zhai
2020-04-10 12:44 ` Greg Kroah-Hartman
2020-04-13 5:02 ` Orson Zhai [this message]
2020-04-15 16:31 ` Orson Zhai
2020-04-15 18:48 ` Jason Baron
2020-04-16 2:01 ` Orson Zhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413050241.GA5694@lenovo \
--to=orson.unisoc@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orson.zhai@unisoc.com \
--cc=orsonzhai@gmail.com \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).