From: Borislav Petkov <bp@alien8.de>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Christoph Hellwig <hch@lst.de>, Yash Shah <yash.shah@sifive.com>,
linux-edac@vger.kernel.org,
Sebastian Duda <sebastian.duda@fau.de>,
Joe Perches <joe@perches.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] MAINTAINERS: rectify EDAC-SIFIVE entry
Date: Mon, 13 Apr 2020 10:15:56 +0200 [thread overview]
Message-ID: <20200413081556.GB3772@zn.tnic> (raw)
In-Reply-To: <20200413073447.9284-1-lukas.bulwahn@gmail.com>
On Mon, Apr 13, 2020 at 09:34:47AM +0200, Lukas Bulwahn wrote:
> Commit 9209fb51896f ("riscv: move sifive_l2_cache.c to drivers/soc") moved
> arch/riscv/mm/sifive_l2_cache.c to drivers/soc/sifive/sifive_l2_cache.c
> and adjusted the MAINTAINERS EDAC-SIFIVE entry but slipped in a mistake.
>
> Since then, ./scripts/get_maintainer.pl --self-test complains:
>
> warning: no file matches F: drivers/soc/sifive_l2_cache.c
>
> Rectify the EDAC-SIFIVE entry in MAINTAINERS now.
>
> Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Paul, please pick this patch.
>
> v1: https://lore.kernel.org/lkml/20200304144045.15060-1-lukas.bulwahn@gmail.com/
> - was not picked up.
>
> v1-resend: applies on v5.7-rc1
>
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e64e5db31497..e28676766b26 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6172,7 +6172,7 @@ M: Yash Shah <yash.shah@sifive.com>
> L: linux-edac@vger.kernel.org
> S: Supported
> F: drivers/edac/sifive_edac.c
> -F: drivers/soc/sifive_l2_cache.c
> +F: drivers/soc/sifive/sifive_l2_cache.c
Looking at that a bit - I think the right thing to do is to remove that
sifive_l2_cache.c file from the EDAC-SIFIVE file pattern because the
edac driver is simply using the L2 thing to register on its notifier
chain, i.e., using an external facility, like all the drivers do. And the
l2_cache thing is not part of the edac driver.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-04-13 8:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 7:34 [PATCH RESEND] MAINTAINERS: rectify EDAC-SIFIVE entry Lukas Bulwahn
2020-04-13 8:15 ` Borislav Petkov [this message]
2020-04-13 12:00 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413081556.GB3772@zn.tnic \
--to=bp@alien8.de \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=paul.walmsley@sifive.com \
--cc=sebastian.duda@fau.de \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).