From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 941FCC2BA19 for ; Mon, 13 Apr 2020 15:44:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73D7C20732 for ; Mon, 13 Apr 2020 15:44:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730692AbgDMPos convert rfc822-to-8bit (ORCPT ); Mon, 13 Apr 2020 11:44:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:53098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728597AbgDMPor (ORCPT ); Mon, 13 Apr 2020 11:44:47 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95DE220656; Mon, 13 Apr 2020 15:44:46 +0000 (UTC) Date: Mon, 13 Apr 2020 11:44:44 -0400 From: Steven Rostedt To: =?UTF-8?B?5a6L54mn5pil?= Cc: mingo@kernel.org, peterz@infradead.org, juri.lelli@redhat.com, Vincent Guittot , dietmar.eggemann@arm.com, Benjamin Segall , mgorman@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched/fair: add __init to sched_init_granularity functions Message-ID: <20200413114444.5db76182@gandalf.local.home> In-Reply-To: References: <20200406074750.56533-1-songmuchun@bytedance.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Apr 2020 23:07:03 +0800 宋牧春 wrote: > > -void sched_init_granularity(void) > > +void __init sched_init_granularity(void) > > { > > update_sysctl(); > > } > > -- > > 2.11.0 > > > > Ping guys. Any suggestions? Seems fine, but not that big of an issue as it's a very small function. ffffffff81136880 : ffffffff81136880: e8 7b b3 ac 00 callq ffffffff81c01c00 <__fentry__> ffffffff81136881: R_X86_64_PLT32 __fentry__-0x4 ffffffff81136885: e9 86 86 ff ff jmpq ffffffff8112ef10 ffffffff8113688a: 66 0f 1f 44 00 00 nopw 0x0(%rax,%rax,1) But anyway, it can save 16 bytes of memory in the running kernel. Reviewed-by: Steven Rostedt (VMware) -- Steve