From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C16C2BA19 for ; Mon, 13 Apr 2020 12:53:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 956522073E for ; Mon, 13 Apr 2020 12:53:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586782414; bh=ejpdoK6nCyovUTodcgI+x/yIdqO1GdrH6k62EYHDX/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OJTfWFY2z3CgXprqb+7hVpFQIf5IT6dCA44KqPAqwIsvWi78Pz4e5Ko8sWgQLGYW3 Nqt8fXWu9goVXX0iMvbpV4vpdxPmtomXbmHFzTTGOjiWjGUszEjnOtTn86T5WvQGKm F7KxAv+mzxrVa9PrsKMdwMBXz+2kTJkT0xZlRGS8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729267AbgDMMxc (ORCPT ); Mon, 13 Apr 2020 08:53:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:52464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728683AbgDMMvn (ORCPT ); Mon, 13 Apr 2020 08:51:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 40A7E2073E; Mon, 13 Apr 2020 12:51:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586782302; bh=ejpdoK6nCyovUTodcgI+x/yIdqO1GdrH6k62EYHDX/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wv9jiJj171n/VbX1/Oz+CDoFDAXgADnSrXt4yq4K9JyfAma1u+FgtbwvYQuGSH31M 7RE2ZNinmeytr5BiBQB/J44cUZdQ9f8xVCdgKFVd8nceGeg7l3kyp8rNBZQH+aKE+j 4w5D+kkaXwA+B3rkz1U52/jflGs0SrTzJMLcDCq4= Date: Mon, 13 Apr 2020 14:51:40 +0200 From: Greg KH To: carlosteniswarrior@gmail.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: Comedi: Drivers: das08: Fixed some coding style issues Message-ID: <20200413125140.GC3077651@kroah.com> References: <20200413080555.29267-1-carlosteniswarrior@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200413080555.29267-1-carlosteniswarrior@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2020 at 10:05:55AM +0200, carlosteniswarrior@gmail.com wrote: > Fixed a coding style issue caused by some declarations that weren't separated. > > Signed-off-by: Carlos Guerrero Alvarez Your From: line in your email client does not match with this :( > --- > drivers/staging/comedi/drivers/das08.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/comedi/drivers/das08.c b/drivers/staging/comedi/drivers/das08.c > index 65e5f2e6c122..f884f5841788 100644 > --- a/drivers/staging/comedi/drivers/das08.c > +++ b/drivers/staging/comedi/drivers/das08.c > @@ -141,7 +141,9 @@ static const struct comedi_lrange *const das08_ai_lranges[] = { > static const int das08_pgh_ai_gainlist[] = { > 8, 0, 10, 2, 12, 4, 14, 6, 1, 3, 5, 7 > }; > + > static const int das08_pgl_ai_gainlist[] = { 8, 0, 2, 4, 6, 1, 3, 5, 7 }; > + > static const int das08_pgm_ai_gainlist[] = { 8, 0, 10, 12, 14, 9, 11, 13, 15 }; What is wrong with the original code? It makes more sense, don't you think? greg k-h