From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E084BC2BA19 for ; Mon, 13 Apr 2020 17:19:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B22272072D for ; Mon, 13 Apr 2020 17:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586798386; bh=yY0rQs26mjwo4CRbKLXgGHPV+jq13LwUqB+ccE+/pe0=; h=Date:From:To:Subject:References:In-Reply-To:List-ID:From; b=OascJqXqE7or2eCbamZm8JLvlyz4PlSMR7Cs4FBy7oe6E2w0Fg9bR3iNShJLOlv71 wG3YTMiagQRLfU8L551PTXbA1dPG2zA+URykw0e414srJ8yz0FEAhPlWbsT7nZp6xV jeWaHHFMCbwnRRm/6tcImp+yu3hT9VwBYmuKPxxM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732742AbgDMRTp (ORCPT ); Mon, 13 Apr 2020 13:19:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:40942 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732579AbgDMRTl (ORCPT ); Mon, 13 Apr 2020 13:19:41 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7AC812072D; Mon, 13 Apr 2020 17:19:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586798380; bh=yY0rQs26mjwo4CRbKLXgGHPV+jq13LwUqB+ccE+/pe0=; h=Date:From:To:Subject:References:In-Reply-To:From; b=uZ/ita1yPNr1a1qgXhNls0aieUWKSAAYdLNicKnjmj9eKyTlQyTZkfniKFh9d7VQO 2ac426AbiSNfdEX10f/FGijnIrA/EgffOFLZkisvYKHVDG4edX7iSGPIF1C6sl26jV 64dQnlAUcedSsPWRy4dYWbbT2FSScP63Z0+xC7W4= Date: Mon, 13 Apr 2020 13:19:39 -0400 From: Sasha Levin To: dsterba@suse.cz, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.6 64/68] btrfs: hold a ref on the root in btrfs_recover_relocation Message-ID: <20200413171939.GQ27528@sasha-vm> References: <20200410034634.7731-1-sashal@kernel.org> <20200410034634.7731-64-sashal@kernel.org> <20200410100906.GH5920@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200410100906.GH5920@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 10, 2020 at 12:09:06PM +0200, David Sterba wrote: >On Thu, Apr 09, 2020 at 11:46:29PM -0400, Sasha Levin wrote: >> From: Josef Bacik >> >> [ Upstream commit 932fd26df8125a5b14438563c4d3e33f59ba80f7 ] >> >> We look up the fs root in various places in here when recovering from a >> crashed relcoation. Make sure we hold a ref on the root whenever we >> look them up. >> >> Signed-off-by: Josef Bacik >> Reviewed-by: David Sterba >> Signed-off-by: David Sterba >> Signed-off-by: Sasha Levin > >Please drop this patch from all stable versions. It's part of a >larger series that is preparatory switching from SRCU to refcounts, so >the patch on itself does not fix anything. I've dropped it, thanks! -- Thanks, Sasha