From: Borislav Petkov <bp@alien8.de>
To: boris.ostrovsky@oracle.com, jgross@suse.com
Cc: "Frédéric Pierret (fepitre)" <frederic.pierret@qubes-os.org>,
sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com,
x86@kernel.org, hpa@zytor.com, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xen x86: fix early boot crash with gcc-10
Date: Mon, 13 Apr 2020 19:41:30 +0200 [thread overview]
Message-ID: <20200413174130.GE3772@zn.tnic> (raw)
In-Reply-To: <20200413150314.13974-1-frederic.pierret@qubes-os.org>
On Mon, Apr 13, 2020 at 05:03:14PM +0200, Frédéric Pierret (fepitre) wrote:
> The change fixes boot failure on VM where kernel (at least v5.4 and v5.6)
> is built with gcc-10 and STACKPROTECTOR_STRONG enabled:
>
> ```
> Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: cpu_bringup_and_idle+0x93/0xa0
> CPU: 1 PID: 0 Comm: swapper/1 Not tainted 5.4.31-1.qubes.x86_64 #1
> Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.12.0-1 04/01/2014
> Call Trace:
> dump_stack+0x64/0x88
> panic+0x10b/0x2ed
> ? cpu_bringup_and_idle+0x93/0xa0
> __stack_chk_fail+0x15/0x20
> cpu_bringup_and_idle+0x93/0xa
> ```
> The change makes successfully booting the VM. The VM is hosted by
> KVM hypervisor and is running Xen into.
>
> Based on work done by Sergei Trofimovich: https://lkml.org/lkml/2020/3/26/1133
>
> Signed-off-by: Frédéric Pierret (fepitre) <frederic.pierret@qubes-os.org>
> ---
> arch/x86/xen/smp_pv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
> index 8fb8a50a28b4..5c8ee4a5bb0c 100644
> --- a/arch/x86/xen/smp_pv.c
> +++ b/arch/x86/xen/smp_pv.c
> @@ -88,7 +88,7 @@ static void cpu_bringup(void)
> local_irq_enable();
> }
>
> -asmlinkage __visible void cpu_bringup_and_idle(void)
> +asmlinkage __visible void __no_stack_protector cpu_bringup_and_idle(void)
> {
> cpu_bringup();
> boot_init_stack_canary();
> --
Boris O, Jürgen,
you guys might wanna wait a bit with this one:
https://lkml.kernel.org/r/20200413163540.GD3772@zn.tnic
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2020-04-13 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 12:35 [PATCH] xen x86: fix early boot crash with gcc-10 Frédéric Pierret (fepitre)
2020-04-13 14:20 ` Borislav Petkov
2020-04-13 15:03 ` [PATCH v2] " Frédéric Pierret (fepitre)
2020-04-13 17:41 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413174130.GE3772@zn.tnic \
--to=bp@alien8.de \
--cc=boris.ostrovsky@oracle.com \
--cc=frederic.pierret@qubes-os.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).