From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF1EC2BA2B for ; Mon, 13 Apr 2020 20:03:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CE81206E9 for ; Mon, 13 Apr 2020 20:03:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="juG10l2Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388212AbgDMUDM (ORCPT ); Mon, 13 Apr 2020 16:03:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2388135AbgDMUDJ (ORCPT ); Mon, 13 Apr 2020 16:03:09 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08163C0A3BDC for ; Mon, 13 Apr 2020 13:03:09 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id l25so10852439qkk.3 for ; Mon, 13 Apr 2020 13:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OEtNtfUfCfknsSkfuodbs8GxJYII1GNua8MgFwL7K04=; b=juG10l2QIUDc0d5n1SeOUdB0siwuJQOGCU6pnQRUaf/usairEJnMWI4NCHxVUL2frR HT8Dj0G2KFCEAuDZkPEiGVv3NLV5ooo7kJcA7V4T4xV81925vc++8cQ5KHVSBI1+By+5 +/+66XSDZZW/XkKLCzanTlv78m+KRuVYwmVlKC0N09gqxCMtKrGm1srU2i7+Kw1dkX5x DPoyq7kDqoEsqgMu8qGEr3vtIBlmiQWaBKBOz/tbp3ah+kvBa7aU6x3A1gaLlMlwJUeg hUM97swfra3YIkYNCDFX0ZcS8Au+7KacD3c88l4X9gBMGqiNfPjeT92Va5NYJ5lvz0rD aygw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OEtNtfUfCfknsSkfuodbs8GxJYII1GNua8MgFwL7K04=; b=eJ1QFx/jg6ln3BrBLWdwsn95d4nrXPnqC3UwZRiXhVSmcmWxzyixpGrowQJiy2xZuE HHYXm7GePnuuKwFUUJmSXmO4CrB3peFMDwaFeUf1vnvZharcMxp5Xkl17c/M25UUg+Fo SLtz5ESXlHCxi97Z2zizzx3SvJNGWv/NxxZH6wlnYDtgIShdaYjCuXYYgfebq3AY6Nrn HFyM1BDPP+kQC1yiUzqYEmxpwlhqJIwkMFCkjMwzCa0TnyFm3w5/X+/VQlrk+Z8SWU/A HtptY1L9ayHhQKJOWn0rQrYhGPmF0kRl0excZNdQqquQS9qPY84w/pxiqoaerSqNdpeY B73w== X-Gm-Message-State: AGi0PuaY1/vXEoC87+fsp8XUapG1k2WTmyn5k85sVlJcH2uH6ztuFP2u wSl+9tPpzvgcdAcrfjDdga2Iug== X-Google-Smtp-Source: APiQypJVwvSR1oEkK4bhCoeIIw8batoCJN92/jh4PNjnx+deBvO5XKiPj+RRAmN7IK2twvZnNWUNMA== X-Received: by 2002:a37:d93:: with SMTP id 141mr7293908qkn.32.1586808188246; Mon, 13 Apr 2020 13:03:08 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id x66sm9119423qka.121.2020.04.13.13.03.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2020 13:03:07 -0700 (PDT) Date: Mon, 13 Apr 2020 16:03:06 -0400 From: Johannes Weiner To: Andrii Nakryiko Cc: Christoph Hellwig , Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , x86@kernel.org, David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Robin Murphy , Christophe Leroy , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, bpf , open list Subject: Re: [PATCH 25/28] mm: remove vmalloc_user_node_flags Message-ID: <20200413200306.GC99267@cmpxchg.org> References: <20200408115926.1467567-1-hch@lst.de> <20200408115926.1467567-26-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 09, 2020 at 03:25:03PM -0700, Andrii Nakryiko wrote: > cc Johannes who suggested this API call originally I forgot why we did it this way - probably just cruft begetting more cruft. Either way, Christoph's cleanup makes this look a lot better. > On Wed, Apr 8, 2020 at 5:03 AM Christoph Hellwig wrote: > > > > Open code it in __bpf_map_area_alloc, which is the only caller. Also > > clean up __bpf_map_area_alloc to have a single vmalloc call with > > slightly different flags instead of the current two different calls. > > > > For this to compile for the nommu case add a __vmalloc_node_range stub > > to nommu.c. > > > > Signed-off-by: Christoph Hellwig Acked-by: Johannes Weiner