[PATCH] [PATCH v2] power:supply:88pm860x_battery:remove redundant dev_err message

[PATCH] [PATCH v2] power:supply:88pm860x_battery:remove redundant dev_err message

[Tang Bin]

In the pm860x_battery_probe(),when get irq failed, the function
platform_get_irq() can log an dev_err message,so remove redundant
message here.

Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
Changes from v1
 - changed the theme、commit message and the code,but the purpose is the same.
   The original piece is:https://lore.kernel.org/linux-pm/20200402111222.15204-1-tangbin@cmss.chinamobile.com/
---
 drivers/power/supply/88pm860x_battery.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/power/supply/88pm860x_battery.c b/drivers/power/supply/88pm860x_battery.c
index 5ca047b3f..1308f3a18 100644
--- a/drivers/power/supply/88pm860x_battery.c
+++ b/drivers/power/supply/88pm860x_battery.c
@@ -919,16 +919,12 @@ static int pm860x_battery_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	info->irq_cc = platform_get_irq(pdev, 0);
-	if (info->irq_cc <= 0) {
-		dev_err(&pdev->dev, "No IRQ resource!\n");
+	if (info->irq_cc <= 0)
 		return -EINVAL;
-	}
 
 	info->irq_batt = platform_get_irq(pdev, 1);
-	if (info->irq_batt <= 0) {
-		dev_err(&pdev->dev, "No IRQ resource!\n");
+	if (info->irq_batt <= 0)
 		return -EINVAL;
-	}
 
 	info->chip = chip;
 	info->i2c =
-- 
2.20.1.windows.1

Re: [PATCH] [PATCH v2] power:supply:88pm860x_battery:remove redundant dev_err message

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

Hi,

On Mon, Apr 06, 2020 at 01:07:57PM +0800, Tang Bin wrote:
> In the pm860x_battery_probe(),when get irq failed, the function
> platform_get_irq() can log an dev_err message,so remove redundant
> message here.
> 
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---

Thanks, queued.

-- Sebastian

> Changes from v1
>  - changed the theme、commit message and the code,but the purpose is the same.
>    The original piece is:https://lore.kernel.org/linux-pm/20200402111222.15204-1-tangbin@cmss.chinamobile.com/
> ---
>  drivers/power/supply/88pm860x_battery.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/power/supply/88pm860x_battery.c b/drivers/power/supply/88pm860x_battery.c
> index 5ca047b3f..1308f3a18 100644
> --- a/drivers/power/supply/88pm860x_battery.c
> +++ b/drivers/power/supply/88pm860x_battery.c
> @@ -919,16 +919,12 @@ static int pm860x_battery_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	info->irq_cc = platform_get_irq(pdev, 0);
> -	if (info->irq_cc <= 0) {
> -		dev_err(&pdev->dev, "No IRQ resource!\n");
> +	if (info->irq_cc <= 0)
>  		return -EINVAL;
> -	}
>  
>  	info->irq_batt = platform_get_irq(pdev, 1);
> -	if (info->irq_batt <= 0) {
> -		dev_err(&pdev->dev, "No IRQ resource!\n");
> +	if (info->irq_batt <= 0)
>  		return -EINVAL;
> -	}
>  
>  	info->chip = chip;
>  	info->i2c =
> -- 
> 2.20.1.windows.1
> 
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] [PATCH v2] power:supply:88pm860x_battery:removeredundant dev_err message

[Tang Bin]

Hi Sebastian:

On 2020/4/14 7:04, Sebastian Reichel wrote:
> Thanks, queued.

Thanks!

Tang Bin

>
>
>