From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: qcom: fix wrong write in update_dual_edge
Date: Mon, 13 Apr 2020 18:04:05 -0700 [thread overview]
Message-ID: <20200414010405.GH20625@builder.lan> (raw)
In-Reply-To: <20200414003726.25347-1-ansuelsmth@gmail.com>
On Mon 13 Apr 17:37 PDT 2020, Ansuel Smith wrote:
> Fix a typo in the readl/writel accessor conversion where val is used
> instead of pol changing the behavior of the original code.
>
> Fixes: 6c73698904aa pinctrl: qcom: Introduce readl/writel accessors
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Thank you Ansuel
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Linus, when you apply this please add
Cc: stable@vger.kernel.org
Thanks,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 1a948c3f54b7..9f1c9951949e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -692,7 +692,7 @@ static void msm_gpio_update_dual_edge_pos(struct msm_pinctrl *pctrl,
>
> pol = msm_readl_intr_cfg(pctrl, g);
> pol ^= BIT(g->intr_polarity_bit);
> - msm_writel_intr_cfg(val, pctrl, g);
> + msm_writel_intr_cfg(pol, pctrl, g);
>
> val2 = msm_readl_io(pctrl, g) & BIT(g->in_bit);
> intstat = msm_readl_intr_status(pctrl, g);
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-04-14 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 0:37 [PATCH] pinctrl: qcom: fix wrong write in update_dual_edge Ansuel Smith
2020-04-14 1:04 ` Bjorn Andersson [this message]
2020-04-16 11:16 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414010405.GH20625@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).