linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Wainer dos Santos Moschetta <wainersm@redhat.com>,
	pbonzini@redhat.com, kvm@vger.kernel.org, david@redhat.com,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	krish.sadhukhan@oracle.com
Subject: Re: [PATCH v5 0/2] selftests: kvm: Introduce the mem_slot_test test
Date: Tue, 14 Apr 2020 08:16:54 +0200	[thread overview]
Message-ID: <20200414061654.qhuo3hsslz32qwgc@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20200410204509.GK22482@linux.intel.com>

On Fri, Apr 10, 2020 at 01:45:09PM -0700, Sean Christopherson wrote:
> On Thu, Apr 09, 2020 at 07:09:03PM -0300, Wainer dos Santos Moschetta wrote:
> > This series introduces a new KVM selftest (mem_slot_test) that goal
> > is to verify memory slots can be added up to the maximum allowed. An
> > extra slot is attempted which should occur on error.
> > 
> > The patch 01 is needed so that the VM fd can be accessed from the
> > test code (for the ioctl call attempting to add an extra slot).
> > 
> > I ran the test successfully on x86_64, aarch64, and s390x.  This
> > is why it is enabled to build on those arches.
> 
> Any objection to folding these patches into a series I have to clean up
> set_memory_region_test (which was mentioned in a prior version) and add
> this as a testcase to set_memory_region_test instead of creating a whole
> new test?
> 
> A large chunk of set_memory_region_test will still be x86_64 only, but
> having the test reside in common code will hopefully make it easier to
> extend to other architectures.
>

Yes, that would be my preference as well. Eventually I decided it could be
done later, but I still prefer it being done from the beginning.

Thanks,
drew 


      reply	other threads:[~2020-04-14  6:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09 22:09 [PATCH v5 0/2] selftests: kvm: Introduce the mem_slot_test test Wainer dos Santos Moschetta
2020-04-09 22:09 ` [PATCH v5 1/2] selftests: kvm: Add vm_get_fd() in kvm_util Wainer dos Santos Moschetta
2020-04-09 22:09 ` [PATCH v5 2/2] selftests: kvm: Add mem_slot_test test Wainer dos Santos Moschetta
2020-04-10 20:45 ` [PATCH v5 0/2] selftests: kvm: Introduce the " Sean Christopherson
2020-04-14  6:16   ` Andrew Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200414061654.qhuo3hsslz32qwgc@kamzik.brq.redhat.com \
    --to=drjones@redhat.com \
    --cc=david@redhat.com \
    --cc=krish.sadhukhan@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).