From: Borislav Petkov <bp@alien8.de>
To: Jason Yan <yanaijie@huawei.com>
Cc: khuong@os.amperecomputing.com, mchehab@kernel.org,
tony.luck@intel.com, james.morse@arm.com, rrichter@marvell.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] EDAC, xgene: remove set but not used 'address'
Date: Tue, 14 Apr 2020 14:47:31 +0200 [thread overview]
Message-ID: <20200414124731.GB31737@zn.tnic> (raw)
In-Reply-To: <20200409093259.20069-1-yanaijie@huawei.com>
On Thu, Apr 09, 2020 at 05:32:59PM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/edac/xgene_edac.c:1486:7: warning: variable ‘address’ set but
> not used [-Wunused-but-set-variable]
> u32 address;
> ^~~~~~~
> And remove the unused macro RBERRADDR_RD after that.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/edac/xgene_edac.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c
> index e4a1032ba0b5..1d2c27a00a4a 100644
> --- a/drivers/edac/xgene_edac.c
> +++ b/drivers/edac/xgene_edac.c
> @@ -1349,7 +1349,6 @@ static int xgene_edac_l3_remove(struct xgene_edac_dev_ctx *l3)
> #define WORD_ALIGNED_ERR_MASK BIT(28)
> #define PAGE_ACCESS_ERR_MASK BIT(27)
> #define WRITE_ACCESS_MASK BIT(26)
> -#define RBERRADDR_RD(src) ((src) & 0x03FFFFFF)
>
> static const char * const soc_mem_err_v1[] = {
> "10GbE0",
> @@ -1483,13 +1482,11 @@ static void xgene_edac_rb_report(struct edac_device_ctl_info *edac_dev)
> return;
> if (reg & STICKYERR_MASK) {
> bool write;
> - u32 address;
>
> dev_err(edac_dev->dev, "IOB bus access error(s)\n");
> if (regmap_read(ctx->edac->rb_map, RBEIR, ®))
> return;
> write = reg & WRITE_ACCESS_MASK ? 1 : 0;
> - address = RBERRADDR_RD(reg);
> if (reg & AGENT_OFFLINE_ERR_MASK)
> dev_err(edac_dev->dev,
> "IOB bus %s access to offline agent error\n",
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2020-04-14 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 9:32 [PATCH v2] EDAC, xgene: remove set but not used 'address' Jason Yan
2020-04-14 12:47 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414124731.GB31737@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=khuong@os.amperecomputing.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).