From: Dejin Zheng <zhengdejin5@gmail.com>
To: linus.walleij@linaro.org, patrice.chotard@st.com, info@metux.net,
allison@lohutok.net, nehal-bakulchandra.shah@amd.com,
andriy.shevchenko@linux.intel.com, tglx@linutronix.de,
linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Dejin Zheng <zhengdejin5@gmail.com>
Subject: [PATCH v1] i2c: img-scb: remove duplicate dev_err()
Date: Tue, 14 Apr 2020 22:26:50 +0800 [thread overview]
Message-ID: <20200414142650.29359-1-zhengdejin5@gmail.com> (raw)
it will print an error message by itself when platform_get_irq()
goes wrong. so don't need dev_err() in here again.
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
---
drivers/i2c/busses/i2c-img-scb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c
index 422097a31c95..2f6de763816a 100644
--- a/drivers/i2c/busses/i2c-img-scb.c
+++ b/drivers/i2c/busses/i2c-img-scb.c
@@ -1344,10 +1344,8 @@ static int img_i2c_probe(struct platform_device *pdev)
return PTR_ERR(i2c->base);
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "can't get irq number\n");
+ if (irq < 0)
return irq;
- }
i2c->sys_clk = devm_clk_get(&pdev->dev, "sys");
if (IS_ERR(i2c->sys_clk)) {
--
2.25.0
next reply other threads:[~2020-04-14 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 14:26 Dejin Zheng [this message]
2020-04-14 14:38 ` [PATCH v1] i2c: img-scb: remove duplicate dev_err() Andy Shevchenko
2020-04-14 15:50 ` Dejin Zheng
2020-04-14 16:20 ` Andy Shevchenko
2020-04-14 16:42 ` Wolfram Sang
2020-04-14 16:46 ` Andy Shevchenko
2020-04-14 16:56 ` Wolfram Sang
2020-04-14 15:48 Markus Elfring
2020-04-15 2:54 ` Dejin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414142650.29359-1-zhengdejin5@gmail.com \
--to=zhengdejin5@gmail.com \
--cc=allison@lohutok.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=info@metux.net \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=patrice.chotard@st.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).