From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48877C2BB55 for ; Wed, 15 Apr 2020 12:52:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BC88206D5 for ; Wed, 15 Apr 2020 12:52:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586955177; bh=7XeeStrCK5kGavojARUQVC9UvgsLzqP+H2GH7ek/uyM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=DmeYIvqFaGtYDEO4c1yAvZwgKn0vtqNSnR9NreAqNARZd13/NsV3gx7MGLaI48ku6 RYV6oxe6G/6lrCFi4n+x8Mv1cXU4ipWQMVym2RvYJ9Gd1wzMzmj/0hlvXSyAnYVO0p YywUx7LGFBPVHEOhDaSnOQHqViOThIczuqkmCwnQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S370555AbgDOMwy (ORCPT ); Wed, 15 Apr 2020 08:52:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:33866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2897469AbgDOLme (ORCPT ); Wed, 15 Apr 2020 07:42:34 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BB952137B; Wed, 15 Apr 2020 11:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586950954; bh=7XeeStrCK5kGavojARUQVC9UvgsLzqP+H2GH7ek/uyM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Eh6UNaTd0bAPE6LUIUA4nbKadqnaNTdP2FNFflUWVaV5bpaC6N62aD4Li9NIuYDeW WC+fCHMd0q0I2yuW8QgzKVkdKR0GZ69q9nodIbF4d2jj4slw7zQ8EEyNiaWIz02u3V 2+iSOcX5uaCmI5IQXSrYRXZHH3lPdYRxz/Ik07xk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Aya Levin , Saeed Mahameed , Sasha Levin , netdev@vger.kernel.org, linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 5.5 006/106] net/mlx5e: Enforce setting of a single FEC mode Date: Wed, 15 Apr 2020 07:40:46 -0400 Message-Id: <20200415114226.13103-6-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200415114226.13103-1-sashal@kernel.org> References: <20200415114226.13103-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aya Levin [ Upstream commit 4bd9d5070b92da012f2715cf8e4859acb78b8f35 ] Ethtool command allow setting of several FEC modes in a single set command. The driver can only set a single FEC mode at a time. With this patch driver will reply not-supported on setting several FEC modes. Signed-off-by: Aya Levin Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c index c6776f308d5e6..ce63f9bd10fa8 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c @@ -1554,6 +1554,10 @@ static int mlx5e_set_fecparam(struct net_device *netdev, int mode; int err; + if (bitmap_weight((unsigned long *)&fecparam->fec, + ETHTOOL_FEC_BASER_BIT + 1) > 1) + return -EOPNOTSUPP; + for (mode = 0; mode < ARRAY_SIZE(pplm_fec_2_ethtool); mode++) { if (!(pplm_fec_2_ethtool[mode] & fecparam->fec)) continue; -- 2.20.1