From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42935C2BB55 for ; Wed, 15 Apr 2020 12:03:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 140E220575 for ; Wed, 15 Apr 2020 12:03:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586952225; bh=Io7ZAUQgTGEVP6jfptqaQMhzw5ws1pAVV5VQMKGqF0s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mQDlvxYMj0C2KMzyj4u7ESrMVx8gvYKPszUTSjHHoiZFZv3OcyjtQlsCYn68DA+rP aHZps53ayxaW3CNsyKs6vaGxUk4Jlxl8rlhjjjez9LF02aZSdzhJZXgWxZN9YOGclR Kk8X7vxe0QVOkbNm6AauCyWURAfDVcl9TG7sx6P4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S368266AbgDOMDn (ORCPT ); Wed, 15 Apr 2020 08:03:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:44044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2409457AbgDOLsX (ORCPT ); Wed, 15 Apr 2020 07:48:23 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1AFED20768; Wed, 15 Apr 2020 11:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586951303; bh=Io7ZAUQgTGEVP6jfptqaQMhzw5ws1pAVV5VQMKGqF0s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bxbNcmyyeOEqWO2kJb3MEGb7mw/MqL+1QQDOc9AEyjidah8aj9Lw4kty1ItK1dCCf 2LHlndyVcrbO6Dh5JAEHP3e4BIFr3MFN2ATGHZJMhxijMk5Uba8FPpJHGZEISB+j4j +hsUulfalAKnJzl3ckguTBWc8QBY1gAAQIwqZr/8= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Richard Palethorpe , Kees Cook , linux-can@vger.kernel.org, netdev@vger.kernel.org, security@kernel.org, wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net, Sasha Levin Subject: [PATCH AUTOSEL 4.4 07/14] slcan: Don't transmit uninitialized stack data in padding Date: Wed, 15 Apr 2020 07:48:07 -0400 Message-Id: <20200415114814.15954-7-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200415114814.15954-1-sashal@kernel.org> References: <20200415114814.15954-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Richard Palethorpe [ Upstream commit b9258a2cece4ec1f020715fe3554bc2e360f6264 ] struct can_frame contains some padding which is not explicitly zeroed in slc_bump. This uninitialized data will then be transmitted if the stack initialization hardening feature is not enabled (CONFIG_INIT_STACK_ALL). This commit just zeroes the whole struct including the padding. Signed-off-by: Richard Palethorpe Fixes: a1044e36e457 ("can: add slcan driver for serial/USB-serial CAN adapters") Reviewed-by: Kees Cook Cc: linux-can@vger.kernel.org Cc: netdev@vger.kernel.org Cc: security@kernel.org Cc: wg@grandegger.com Cc: mkl@pengutronix.de Cc: davem@davemloft.net Acked-by: Marc Kleine-Budde Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/can/slcan.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c index 27f42763eaf5a..5bacb019ec1f8 100644 --- a/drivers/net/can/slcan.c +++ b/drivers/net/can/slcan.c @@ -147,7 +147,7 @@ static void slc_bump(struct slcan *sl) u32 tmpid; char *cmd = sl->rbuff; - cf.can_id = 0; + memset(&cf, 0, sizeof(cf)); switch (*cmd) { case 'r': @@ -186,8 +186,6 @@ static void slc_bump(struct slcan *sl) else return; - *(u64 *) (&cf.data) = 0; /* clear payload */ - /* RTR frames may have a dlc > 0 but they never have any data bytes */ if (!(cf.can_id & CAN_RTR_FLAG)) { for (i = 0; i < cf.can_dlc; i++) { -- 2.20.1