From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5261C2BA19 for ; Wed, 15 Apr 2020 13:44:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F7D020857 for ; Wed, 15 Apr 2020 13:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586958271; bh=LBaT8ZJQGI5DoX0BaOKcay3nNpJ8jL6vioLVwcpw1hM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=O183YQEi0kj/nk8nFW7USuQkfoJUbXv//jaGRJN4PNRwh3trN+0iq59O9cb6LhgFn IKGFbuiUy8Z/e5K/Y27cvbeL1WD4fmdlKEs7WFGhmD3IEAAE/9wMF3zX4cPIcOnX+3 wZmQbYaDnrbSykQAPjHdhrzO5qAwu3lI42GZ2pes= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2633530AbgDONo2 (ORCPT ); Wed, 15 Apr 2020 09:44:28 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:38760 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730647AbgDONoW (ORCPT ); Wed, 15 Apr 2020 09:44:22 -0400 Received: by mail-ed1-f66.google.com with SMTP id e5so4874383edq.5; Wed, 15 Apr 2020 06:44:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ue1uYbSCM3f3qpA8DP0y7k1ImrV8BLgfQdpHr8wCsNY=; b=rpO9MnuZ7LUd/ZIOmj2qbKe0/TaEjah/TLCxkZpXoXGjK/A3yPVenorS7cbNxROyh7 WfrRYLna0DDCJX9HtDBU9Tbt0TcWRQ7g8YIGVUmRNB1eT2VySRHIAPGFUzs0PR4ZDAM3 gLwZzmwMxxNsOBlwzCj/81AChokwFjuV2BEmeZMVa5ONQ6B0lvkEe6dx11hrNXlKjPGB PVPGEVLBOgme4fJu727b3Zn4fVRmtzfApq6jFdwMacNwRK8TJ+XvKDO/eYML/ZW7EFD6 bLqAhgpREjkbK5m8Mizjp0mlUttn56QaIDDyAcysI7ZO7EdXf/E8dQHxSEXAqJqhMagR Ahnw== X-Gm-Message-State: AGi0Pua+I8RsrF+K0p94JD3SRwtP2Pa6sEZ4fTZ32X0fVJWvvwSE81v2 6ujeTK0oP6HHd4LFsORbvwjpodqc X-Google-Smtp-Source: APiQypKNYzTDTcjJXJkyJ1tW3CmeNRTTMuezBm45FxKlxDAUOBaCIldgd2OqLmdaCh5e2z6JTgFDtA== X-Received: by 2002:a17:907:118b:: with SMTP id uz11mr4894575ejb.89.1586958259236; Wed, 15 Apr 2020 06:44:19 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id bs8sm2626297ejb.92.2020.04.15.06.44.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Apr 2020 06:44:18 -0700 (PDT) Date: Wed, 15 Apr 2020 15:44:15 +0200 From: Krzysztof Kozlowski To: "H. Nikolaus Schaller" Cc: Jonathan Bakker , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Tony Lindgren , Paul Cercueil , Ralf Baechle , Paul Burton , James Hogan , Kukjin Kim , Maxime Ripard , Chen-Yu Tsai , Thomas Bogendoerfer , Philipp Rossak , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-omap@vger.kernel.org, openpvrsgx-devgroup@letux.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" Subject: Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node Message-ID: <20200415134415.GA21120@kozik-lap> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2020 at 02:50:31PM +0200, H. Nikolaus Schaller wrote: > > > Am 15.04.2020 um 13:49 schrieb Krzysztof Kozlowski : > > > > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: > >> > >> From: Jonathan Bakker > >> > >> to add support for SGX540 GPU. > > > > Do not continue the subject in commit msg like it is one sentence. > > These are two separate sentences, so commit msg starts with capital > > letter and it is sentence by itself. > > > >> Signed-off-by: Jonathan Bakker > >> Signed-off-by: H. Nikolaus Schaller > >> --- > >> arch/arm/boot/dts/s5pv210.dtsi | 15 +++++++++++++++ > >> 1 file changed, 15 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi > >> index 2ad642f51fd9..e7fc709c0cca 100644 > >> --- a/arch/arm/boot/dts/s5pv210.dtsi > >> +++ b/arch/arm/boot/dts/s5pv210.dtsi > >> @@ -512,6 +512,21 @@ vic3: interrupt-controller@f2300000 { > >> #interrupt-cells = <1>; > >> }; > >> > >> + g3d: g3d@f3000000 { > >> + compatible = "samsung,s5pv210-sgx540-120"; > >> + reg = <0xf3000000 0x10000>; > >> + interrupt-parent = <&vic2>; > >> + interrupts = <10>; > >> + clock-names = "sclk"; > >> + clocks = <&clocks CLK_G3D>; > > > > Not part of bindings, please remove or add to the bindings. > > Well, the bindings should describe what is common for all SoC > and they are quite different in what they need in addition. > > Thererfore we have no "additionalProperties: false" in the > bindings [PATCH v6 01/12]. If these properties are needed for Exynos-specific implementation, they should be in the bindings. If they are not needed, they should not be here. Take a look at midgard bindings for example. This is a nice starting point for these here. Best regards, Krzysztof