Re: media/master bisection: v4l2-compliance-vivid.device-presence on qemu_x86_64

[Mauro Carvalho Chehab <mchehab+huawei@kernel.org>]

Em Wed, 15 Apr 2020 10:36:04 +0100
Guillaume Tucker <guillaume.tucker@collabora.com> escreveu:

> On 15/04/2020 10:28, Guillaume Tucker wrote:
> > On 14/04/2020 22:43, Guillaume Tucker wrote:  
> >> On 14/04/2020 22:33, Mauro Carvalho Chehab wrote:  
> >>> Em Tue, 14 Apr 2020 22:23:52 +0100
> >>> Guillaume Tucker <guillaume.tucker@collabora.com> escreveu:
> >>>  
> >>>> Please see the bisection report below about absence of the vivid
> >>>> driver, which caused v4l2-compliance to fail to run.
> >>>>
> >>>> Presumably we need to update the configuration fragment used by
> >>>> kernelci.org to enable platform drivers.  Until now we've been
> >>>> using this:
> >>>>
> >>>>     CONFIG_MEDIA_SUPPORT=y
> >>>>     CONFIG_MEDIA_CAMERA_SUPPORT=y
> >>>>     CONFIG_VIDEO_DEV=y
> >>>>     CONFIG_VIDEO_V4L2=y
> >>>>     CONFIG_V4L_TEST_DRIVERS=y
> >>>>     CONFIG_VIDEO_VIVID=y
> >>>>     CONFIG_VIDEO_VIVID_MAX_DEVS=64
> >>>>
> >>>> Do we simply need to add this one in v5.7 onwards?
> >>>>
> >>>>     CONFIG_MEDIA_PLATFORM_SUPPORT=y  
> >>>
> >>> No, this shouldn't be needed.
> >>>
> >>> Helen sent us a patch that should likely fix it:
> >>>
> >>> 	https://git.linuxtv.org/media_tree.git/commit/?id=860b511766a3d95308a942ac09a34e4d1839e706
> >>>
> >>> Could you please check if this solves the issue?  
> >>
> >> I see, thanks.  This revision is being built and tested at the
> >> moment, I'll check the results when they land in my inbox.  
> > 
> > Helen's patch was needed, but there were still a couple of
> > issues.  First we need to enable this extra option now in the
> > config fragment:
> > 
> >     CONFIG_MEDIA_TEST_SUPPORT=y

Yes.

Another option would be to do:

	# MEDIA_SUPPORT_FILTER is not set

With this option (enabled by default if EMBEDDED or EXPERT),
all CONFIG_MEDIA_*_SUPPORT will be selected[1].

[1] except for CONFIG_MEDIA_CEC_SUPPORT. This doesn't
    depend on MEDIA_SUPPORT anymore.

> > 
> > as test_drivers/Kconfig starts with "if MEDIA_TEST_SUPPORT".  
> 
> Actually, this "if" seems redundant now in test_drivers/Kconfig
> with my patch to include the file conditionally...  Please let me
> know if we should also drop it and I'll send a v2, or if this
> should be fixed in a different way.

Just one "if MEDIA_TEST_SUPPORT" at the main media/Kconfig
should be enough.

Feel free to send a v2.

Thanks,
Mauro