From: Rob Herring <robh@kernel.org>
To: Ivan Mikhaylov <i.mikhaylov@yadro.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v8 1/2] iio: proximity: provide device tree binding document
Date: Wed, 15 Apr 2020 09:50:21 -0500 [thread overview]
Message-ID: <20200415145021.GA16420@bogus> (raw)
In-Reply-To: <20200406172002.18028-2-i.mikhaylov@yadro.com>
On Mon, Apr 06, 2020 at 08:20:01PM +0300, Ivan Mikhaylov wrote:
> Mostly standard i2c driver with some additional led-current option
> for vcnl3020.
>
> Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com>
> ---
> .../bindings/iio/proximity/vcnl3020.yaml | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/proximity/vcnl3020.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/proximity/vcnl3020.yaml b/Documentation/devicetree/bindings/iio/proximity/vcnl3020.yaml
> new file mode 100644
> index 000000000000..29ab2dee1694
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/proximity/vcnl3020.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: GPL-2.0
Dual license as Jonathan said.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/proximity/vcnl3020.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Integrated Proximity Sensor With Infrared Emitter
> +
> +maintainers:
> + - Ivan Mikhaylov <i.mikhaylov@yadro.com>
> +
> +description: |
> + The VCNL3020 is a fully integrated proximity sensor. Fully integrated means
> + that the infrared emitter is included in the package. It has 16-bit
> + resolution. It includes a signal processing IC and features standard I2C
> + communication interface. It features an interrupt function.
> +
> + Specifications about the devices can be found at:
> + https://www.vishay.com/docs/84150/vcnl3020.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - vishay,vcnl3020
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + description: IRQ line for the proximity sensor
Can drop this.
> + maxItems: 1
> +
> + vdd-supply:
> + description: Regulator that provides power to the sensor
> +
> + vddio-supply:
> + description: Regulator that provides power to the bus
> +
> + vishay,led-current-milliamp:
> + description:
> + IR LED current value with valid Range = 0 to 20d. e.g. 0 = 0 mA,
Should be indented 2 fewer spaces.
> + 1 = 10 mA, 20 = 200 mA (2 = 20 mA = DEFAULT). LED Current is
> + limited to 200 mA for values higher than decimal 20.
Use the 'default' property to define the default.
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
Can drop this as standard units have a type already. However, the
standard unit is '-microamp', so use that. Also, looks like this is
in units of register values, not milliamps. Use microamps (e.g. 200000).
> + - enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17,
> + 18, 19, 20]
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + i2c {
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + proximity@13 {
> + compatible = "vishay,vcnl3020";
> + reg = <0x13>;
> + vishay,led-current-milliamp = <0x14>;
> + };
> + };
> --
> 2.21.1
>
next prev parent reply other threads:[~2020-04-15 14:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 17:20 [PATCH v8 0/2] iio: proximity: driver for vcnl3020 Ivan Mikhaylov
2020-04-06 17:20 ` [PATCH v8 1/2] iio: proximity: provide device tree binding document Ivan Mikhaylov
2020-04-12 13:05 ` Jonathan Cameron
2020-04-15 14:50 ` Rob Herring [this message]
2020-04-06 17:20 ` [PATCH v8 2/2] iio: proximity: Add driver support for vcnl3020 proximity sensor Ivan Mikhaylov
2020-04-12 13:17 ` Jonathan Cameron
2020-04-06 17:53 ` [PATCH v8 0/2] iio: proximity: driver for vcnl3020 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415145021.GA16420@bogus \
--to=robh@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=i.mikhaylov@yadro.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).