From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: tomi.valkeinen@ti.com, airlied@linux.ie, daniel@ffwll.ch,
sebastian.reichel@collabora.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] drm/omap: venc: remove unused variable 'venc_config_pal_bdghi'
Date: Wed, 15 Apr 2020 18:39:59 +0300 [thread overview]
Message-ID: <20200415153959.GI4758@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200415132105.43636-1-yuehaibing@huawei.com>
Hi Yue,
Thank you for the patch.
On Wed, Apr 15, 2020 at 09:21:05PM +0800, YueHaibing wrote:
> drivers/gpu/drm/omapdrm/dss/venc.c:211:33:
> warning: 'venc_config_pal_bdghi' defined but not used [-Wunused-const-variable=]
> static const struct venc_config venc_config_pal_bdghi = {
> ^~~~~~~~~~~~~~~~~~~~~
>
> It is never used, remove it.
Tomi, is this the right fix, or should we work on making use of this
structure ?
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/omapdrm/dss/venc.c | 43 ------------------------------
> 1 file changed, 43 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c b/drivers/gpu/drm/omapdrm/dss/venc.c
> index 766553bb2f87..9701843ccf09 100644
> --- a/drivers/gpu/drm/omapdrm/dss/venc.c
> +++ b/drivers/gpu/drm/omapdrm/dss/venc.c
> @@ -208,49 +208,6 @@ static const struct venc_config venc_config_ntsc_trm = {
> .gen_ctrl = 0x00F90000,
> };
>
> -static const struct venc_config venc_config_pal_bdghi = {
> - .f_control = 0,
> - .vidout_ctrl = 0,
> - .sync_ctrl = 0,
> - .hfltr_ctrl = 0,
> - .x_color = 0,
> - .line21 = 0,
> - .ln_sel = 21,
> - .htrigger_vtrigger = 0,
> - .tvdetgp_int_start_stop_x = 0x00140001,
> - .tvdetgp_int_start_stop_y = 0x00010001,
> - .gen_ctrl = 0x00FB0000,
> -
> - .llen = 864-1,
> - .flens = 625-1,
> - .cc_carr_wss_carr = 0x2F7625ED,
> - .c_phase = 0xDF,
> - .gain_u = 0x111,
> - .gain_v = 0x181,
> - .gain_y = 0x140,
> - .black_level = 0x3e,
> - .blank_level = 0x3e,
> - .m_control = 0<<2 | 1<<1,
> - .bstamp_wss_data = 0x42,
> - .s_carr = 0x2a098acb,
> - .l21__wc_ctl = 0<<13 | 0x16<<8 | 0<<0,
> - .savid__eavid = 0x06A70108,
> - .flen__fal = 23<<16 | 624<<0,
> - .lal__phase_reset = 2<<17 | 310<<0,
> - .hs_int_start_stop_x = 0x00920358,
> - .hs_ext_start_stop_x = 0x000F035F,
> - .vs_int_start_x = 0x1a7<<16,
> - .vs_int_stop_x__vs_int_start_y = 0x000601A7,
> - .vs_int_stop_y__vs_ext_start_x = 0x01AF0036,
> - .vs_ext_stop_x__vs_ext_start_y = 0x27101af,
> - .vs_ext_stop_y = 0x05,
> - .avid_start_stop_x = 0x03530082,
> - .avid_start_stop_y = 0x0270002E,
> - .fid_int_start_x__fid_int_start_y = 0x0005008A,
> - .fid_int_offset_y__fid_ext_start_x = 0x002E0138,
> - .fid_ext_start_y__fid_ext_offset_y = 0x01380005,
> -};
> -
> enum venc_videomode {
> VENC_MODE_UNKNOWN,
> VENC_MODE_PAL,
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-04-15 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 13:21 [PATCH -next] drm/omap: venc: remove unused variable 'venc_config_pal_bdghi' YueHaibing
2020-04-15 15:39 ` Laurent Pinchart [this message]
2020-04-16 6:32 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415153959.GI4758@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=tomi.valkeinen@ti.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).