linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: linux-rt@vger.kernel.org, linux-kernel@vger.kernel.org,
	Daniel Wagner <wagi@monom.org>
Subject: Re: [PATCH RT] signal: Prevent double-free of user struct
Date: Wed, 15 Apr 2020 18:46:28 +0200	[thread overview]
Message-ID: <20200415164628.2dgrj4ghvtev45sy@linutronix.de> (raw)
In-Reply-To: <20200407095413.30039-1-matt@codeblueprint.co.uk>

On 2020-04-07 10:54:13 [+0100], Matt Fleming wrote:
> The way user struct reference counting works changed significantly with,
> 
>   fda31c50292a ("signal: avoid double atomic counter increments for user accounting")
> 
> Now user structs are only freed once the last pending signal is
> dequeued. Make sigqueue_free_current() follow this new convention to
> avoid freeing the user struct multiple times and triggering this
> warning:
> 
>  refcount_t: underflow; use-after-free.
>  WARNING: CPU: 0 PID: 6794 at lib/refcount.c:288 refcount_dec_not_one+0x45/0x50
>  Call Trace:
>   refcount_dec_and_lock_irqsave+0x16/0x60
>   free_uid+0x31/0xa0
>   ? schedule_hrtimeout_range_clock+0x104/0x110
>   __dequeue_signal+0x17c/0x190
>   dequeue_signal+0x5a/0x1b0
>   do_sigtimedwait+0x208/0x250
>   __x64_sys_rt_sigtimedwait+0x6f/0xd0
>   do_syscall_64+0x72/0x200
>   entry_SYSCALL_64_after_hwframe+0x49/0xbe

While all this sounds reasonable, may I ask what did you do to trigger
this?
This is v5.6 only, correct?

Sebastian

  reply	other threads:[~2020-04-15 16:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07  9:54 [PATCH RT] signal: Prevent double-free of user struct Matt Fleming
2020-04-15 16:46 ` Sebastian Andrzej Siewior [this message]
2020-04-15 19:05   ` Daniel Wagner
2020-04-16  8:05     ` Sebastian Andrzej Siewior
2020-04-07 14:45 Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200415164628.2dgrj4ghvtev45sy@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=wagi@monom.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).