From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB99FC2BA2B for ; Thu, 16 Apr 2020 06:54:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AA212087E for ; Thu, 16 Apr 2020 06:54:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qUXYZs7y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437039AbgDPGyo (ORCPT ); Thu, 16 Apr 2020 02:54:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2437468AbgDPGy1 (ORCPT ); Thu, 16 Apr 2020 02:54:27 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 536CDC061A0C; Wed, 15 Apr 2020 23:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PhktM7xkiFtBGJ6dx8UYLKoYK1Fp1IPWa9qQEpZldmY=; b=qUXYZs7ybgSXUPkdc9bshfC+TP YyTj+O9gfG0xSQUFcPVmDbSivTYGU6T8/JuO8e+CniEHH5g4brZ+JIjPGkHNQ1Qgd9FQuMnHRH9DA pYH8fUNhGvOZjF3ofrnhGaElg7f6EIZCxYZ7ErJZHnaKVw1IhmGBjHgHu9iYquVmRmQq3Z1R2CDwX 8jyvhp/HLmJlwW8wPJnyfCNCsNlth/WA6d2FKQ0szNVS+hZYuffh7eyhNWbHofsN5HjZc+KXsnQj5 hphNYzS+rYK+nICKfsydWgXQr87HpsubyYPPTg9E5LA0ddCCMxD5mqZ3UUxLFLm3cEFXcundK/gP2 +gLPWsqw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOyPi-00010l-Cc; Thu, 16 Apr 2020 06:54:18 +0000 Date: Wed, 15 Apr 2020 23:54:18 -0700 From: Christoph Hellwig To: NeilBrown Cc: Trond Myklebust , "Anna.Schumaker@Netapp.com" , Andrew Morton , Jan Kara , Michal Hocko , linux-mm@kvack.org, linux-nfs@vger.kernel.org, LKML Subject: Re: [PATCH 1/2 V3] MM: replace PF_LESS_THROTTLE with PF_LOCAL_THROTTLE Message-ID: <20200416065418.GA1092@infradead.org> References: <87tv2b7q72.fsf@notabene.neil.brown.name> <87v9miydai.fsf@notabene.neil.brown.name> <87ftdgw58w.fsf@notabene.neil.brown.name> <87wo6gs26e.fsf@notabene.neil.brown.name> <87tv1ks24t.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tv1ks24t.fsf@notabene.neil.brown.name> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + if (current->flags & PF_LOCAL_THROTTLE) > + /* This task must only be throttled based on the bdi > + * it is writing to - dirty pages for other bdis might > + * be pages this task is trying to write out. So it > + * gets a free pass unless both global and local > + * thresholds are exceeded. i.e unless > + * "dirty_exceeded". > + */ This is not our normal multi-line comment style. The first line should be just a /* Otherwise this looks good.