* [PATCH] Staging: Comedi: Drivers: das08: Fixed some coding style issues
@ 2020-04-13 8:05 carlosteniswarrior
2020-04-13 12:51 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: carlosteniswarrior @ 2020-04-13 8:05 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Carlos Guerrero Alvarez
Fixed a coding style issue caused by some declarations that weren't separated.
Signed-off-by: Carlos Guerrero Alvarez <carlosteniswarrior@gmail.com>
---
drivers/staging/comedi/drivers/das08.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/comedi/drivers/das08.c b/drivers/staging/comedi/drivers/das08.c
index 65e5f2e6c122..f884f5841788 100644
--- a/drivers/staging/comedi/drivers/das08.c
+++ b/drivers/staging/comedi/drivers/das08.c
@@ -141,7 +141,9 @@ static const struct comedi_lrange *const das08_ai_lranges[] = {
static const int das08_pgh_ai_gainlist[] = {
8, 0, 10, 2, 12, 4, 14, 6, 1, 3, 5, 7
};
+
static const int das08_pgl_ai_gainlist[] = { 8, 0, 2, 4, 6, 1, 3, 5, 7 };
+
static const int das08_pgm_ai_gainlist[] = { 8, 0, 10, 12, 14, 9, 11, 13, 15 };
static const int *const das08_ai_gainlists[] = {
--
2.26.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: Comedi: Drivers: das08: Fixed some coding style issues
2020-04-13 8:05 [PATCH] Staging: Comedi: Drivers: das08: Fixed some coding style issues carlosteniswarrior
@ 2020-04-13 12:51 ` Greg KH
[not found] ` <CAB_Ssx7B13Lm-twHuEOzP4EODQ7kqd5jA0mxZS5SnpqxJ65XBg@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-04-13 12:51 UTC (permalink / raw)
To: carlosteniswarrior; +Cc: devel, linux-kernel
On Mon, Apr 13, 2020 at 10:05:55AM +0200, carlosteniswarrior@gmail.com wrote:
> Fixed a coding style issue caused by some declarations that weren't separated.
>
> Signed-off-by: Carlos Guerrero Alvarez <carlosteniswarrior@gmail.com>
Your From: line in your email client does not match with this :(
> ---
> drivers/staging/comedi/drivers/das08.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/comedi/drivers/das08.c b/drivers/staging/comedi/drivers/das08.c
> index 65e5f2e6c122..f884f5841788 100644
> --- a/drivers/staging/comedi/drivers/das08.c
> +++ b/drivers/staging/comedi/drivers/das08.c
> @@ -141,7 +141,9 @@ static const struct comedi_lrange *const das08_ai_lranges[] = {
> static const int das08_pgh_ai_gainlist[] = {
> 8, 0, 10, 2, 12, 4, 14, 6, 1, 3, 5, 7
> };
> +
> static const int das08_pgl_ai_gainlist[] = { 8, 0, 2, 4, 6, 1, 3, 5, 7 };
> +
> static const int das08_pgm_ai_gainlist[] = { 8, 0, 10, 12, 14, 9, 11, 13, 15 };
What is wrong with the original code? It makes more sense, don't you
think?
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: Comedi: Drivers: das08: Fixed some coding style issues
[not found] ` <CAB_Ssx7B13Lm-twHuEOzP4EODQ7kqd5jA0mxZS5SnpqxJ65XBg@mail.gmail.com>
@ 2020-04-16 10:29 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-04-16 10:29 UTC (permalink / raw)
To: Carlos Guerrero Álvarez; +Cc: devel, linux-kernel
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Mon, Apr 13, 2020 at 04:55:08PM +0200, Carlos Guerrero Álvarez wrote:
> What do you mean with the From line?
Look at the patch you sent, the "From:" line on your email does not have
your name, only your email address. Please fix that up when you resend
any future patches.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-16 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 8:05 [PATCH] Staging: Comedi: Drivers: das08: Fixed some coding style issues carlosteniswarrior
2020-04-13 12:51 ` Greg KH
[not found] ` <CAB_Ssx7B13Lm-twHuEOzP4EODQ7kqd5jA0mxZS5SnpqxJ65XBg@mail.gmail.com>
2020-04-16 10:29 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).