From: Masami Hiramatsu <mhiramat@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
linux-mm@kvack.org, Ivan Teterevkov <ivan.teterevkov@nutanix.com>,
Michal Hocko <mhocko@kernel.org>,
David Rientjes <rientjes@google.com>,
Matthew Wilcox <willy@infradead.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
"Guilherme G . Piccoli" <gpiccoli@canonical.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: [PATCH v2 0/3] support setting sysctl parameters from kernel command line
Date: Thu, 16 Apr 2020 15:02:06 +0900 [thread overview]
Message-ID: <20200416150206.d3e103a1a5497b3518d4359c@kernel.org> (raw)
In-Reply-To: <20200415063041.GT11244@42.do-not-panic.com>
Hi Luis,
On Wed, 15 Apr 2020 06:30:41 +0000
Luis Chamberlain <mcgrof@kernel.org> wrote:
> Currently the maximum config size size is 32KB and the total key-words
> (not key-value entries) must be under 1024 nodes. Note: this is not
> the number of entries but nodes, an entry must consume more than 2 nodes
> (a key-word and a value). So theoretically, it will be up to 512
> key-value pairs. If keys contains 3 words in average, it can contain 256
> key-value pairs. In most cases, the number of config items will be under
> 100 entries and smaller than 8KB, so it would be enough. If the node
> number exceeds 1024, parser returns an error even if the file size
> is smaller than 32KB. Anyway, since bootconfig command verifies it when
> appending a boot config to initrd image, user can notice it before
> boot.
> ```
> *recommending* bootconfig due to the limitation of cmdline seems
> sensible, however if we advise that.. wouldn't the space for 512
> theoretical entries full up rather fast?
Yeah, I think it is easier to hit the node number limitation rather
than fill up the space. However, since the bootconfig supports comments,
if user writes enough readable config file, I think it's probably the
right balance :)
If you think the 512 entries is too small, it is easy to expand it
upto 32K (64K nodes). But it may consume 512KB memory only for the
node (meta) data. Current 1024 nodes consumes 8KB (8bytes/node), so
compared with the max data size (32KB), I think it is a better balance.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-04-16 6:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 11:32 [PATCH v2 0/3] support setting sysctl parameters from kernel command line Vlastimil Babka
2020-04-14 11:32 ` [PATCH v2 1/3] kernel/sysctl: " Vlastimil Babka
2020-04-15 3:08 ` Kees Cook
2020-04-15 9:03 ` Masami Hiramatsu
2020-04-16 1:29 ` Luis Chamberlain
2020-04-16 10:49 ` Masami Hiramatsu
2020-04-16 15:53 ` Luis Chamberlain
2020-04-17 10:34 ` Masami Hiramatsu
2020-04-17 16:59 ` Luis Chamberlain
2020-04-18 10:12 ` Masami Hiramatsu
2020-04-14 11:32 ` [PATCH v2 2/3] kernel/sysctl: support handling command line aliases Vlastimil Babka
2020-04-14 11:32 ` [PATCH v2 3/3] kernel/hung_task convert hung_task_panic boot parameter to sysctl Vlastimil Babka
2020-04-15 3:23 ` [PATCH v2 0/3] support setting sysctl parameters from kernel command line Masami Hiramatsu
2020-04-15 6:30 ` Luis Chamberlain
2020-04-16 6:02 ` Masami Hiramatsu [this message]
2020-04-16 6:38 ` Luis Chamberlain
2020-04-15 8:56 ` Vlastimil Babka
2020-04-15 10:01 ` Michal Hocko
2020-04-16 6:08 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416150206.d3e103a1a5497b3518d4359c@kernel.org \
--to=mhiramat@kernel.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=christian.brauner@ubuntu.com \
--cc=ebiederm@xmission.com \
--cc=gpiccoli@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivan.teterevkov@nutanix.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).