From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E600DC2BB55 for ; Thu, 16 Apr 2020 15:36:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2AC621D91 for ; Thu, 16 Apr 2020 15:36:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587051384; bh=qBOX0iZTskqyG9+OVlBWyVCjnXKcHvEcHViiJIZo0uM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=YIgOpqvwiRQrz3Ca5+3P1jcS3sEMR6pfeP+KpewQ+bluF06CbQiPPDZyL9BS/xK7C KJqdZjZ/BKgQWLQANqflxNMQCA3Xl+p54PEnEcIwUw983gAZZ5OG3gUx6hrKkqp79J o+ALS829+lNl0opJ/qHQYq1iXtH/D1HIouGZNeb8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395307AbgDPPgX (ORCPT ); Thu, 16 Apr 2020 11:36:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:47572 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2410531AbgDPPgJ (ORCPT ); Thu, 16 Apr 2020 11:36:09 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96ED822242; Thu, 16 Apr 2020 15:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587051368; bh=qBOX0iZTskqyG9+OVlBWyVCjnXKcHvEcHViiJIZo0uM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hieNu+iGSZzJ3N6YlbIBvYAhnyx8PcCzroMmKoBq+Grm18Cj7SkbOIFvR1Xil2LaB 9AyomDD0uJ/Xbf2bqVdCQl8LOalDvNbi49WHX9dN2C4CXqYMuYWgaJ0XVEuZZY//Bc PbhihFe9vTPCGQ/tdzNJq+FNiuc4UffvGnJwLJiA= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jP6Yg-003utE-Rp; Thu, 16 Apr 2020 16:36:07 +0100 Date: Thu, 16 Apr 2020 16:36:05 +0100 From: Marc Zyngier To: Zenghui Yu Cc: , , , , , Subject: Re: [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK Message-ID: <20200416163605.091fa6eb@why> In-Reply-To: <20200415105746.314-1-yuzenghui@huawei.com> References: <20200415105746.314-1-yuzenghui@huawei.com> Organization: Approximate X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Apr 2020 18:57:46 +0800 Zenghui Yu wrote: > The only user of PTE_S2_MEMATTR_MASK macro had been removed since > commit a501e32430d4 ("arm64: Clean up the default pgprot setting"). > It has been about six years and no one has used it again. > > Let's drop it. > > Signed-off-by: Zenghui Yu > --- > arch/arm64/include/asm/pgtable-hwdef.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/include/asm/pgtable-hwdef.h b/arch/arm64/include/asm/pgtable-hwdef.h > index 6bf5e650da78..99315bdca0e6 100644 > --- a/arch/arm64/include/asm/pgtable-hwdef.h > +++ b/arch/arm64/include/asm/pgtable-hwdef.h > @@ -190,7 +190,6 @@ > * Memory Attribute override for Stage-2 (MemAttr[3:0]) > */ > #define PTE_S2_MEMATTR(t) (_AT(pteval_t, (t)) << 2) > -#define PTE_S2_MEMATTR_MASK (_AT(pteval_t, 0xf) << 2) > > /* > * EL2/HYP PTE/PMD definitions Looks good to me. Catalin, Will: do you want to take this directly? If so please add my: Acked-by: Marc Zyngier Otherwise, I'll route it via the KVM tree. Thanks, M. -- Jazz is not dead. It just smells funny...