From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 366D2C2BB55 for ; Thu, 16 Apr 2020 18:21:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 121FA2223C for ; Thu, 16 Apr 2020 18:21:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="AQM7h/gu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389175AbgDPSVO (ORCPT ); Thu, 16 Apr 2020 14:21:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728495AbgDPSVK (ORCPT ); Thu, 16 Apr 2020 14:21:10 -0400 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C461BC061A0C for ; Thu, 16 Apr 2020 11:21:08 -0700 (PDT) Received: by mail-qv1-xf42.google.com with SMTP id s18so2539563qvn.1 for ; Thu, 16 Apr 2020 11:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VBxNtn9uLGeSV22Vl2rB9fJP9oTr50J1UVIxL3T4SdQ=; b=AQM7h/guHIikQc6/ALmkgldpqSxx+vukOeOKH25qjbdAYokggloytSCSv3uQiNoab+ kmCq0lgWRHsHhVXS/p/KuNMYHolqBV1lhCIlnfGP0GtGI/Hyrk9GYCsTpTg9E5SwNOX9 r7oJF9IbgXygTuDOFxNChu/pX0xNIVcW5M88scZItWJNAHP2v3Q0QliUjLxhlWDActcy 9twFPmO0K9ytT7V+3c9bR+pUOvNs0I0vnxODnP+il1jO3CGGGBnZWWeVC9kw3elxN3BO n+hwJeISZ+kUhd4+QGbmgmQa7fq/FNoQWDw7NlBGiTqRrxMCsVKSTdQXj0vKEpJVbcYm IvrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VBxNtn9uLGeSV22Vl2rB9fJP9oTr50J1UVIxL3T4SdQ=; b=sZRde3DXe3iGRYzgDhAzUHC/qc8pkgLcb91F9+8KJ2ytJOW7cydD9cWn0fd06GF/CU 301uK7utkfc0YBzWbFOaUKdAbG1vaJfsrpx57zrU1E8a02z0ZyBebmNsl5yXUF0ycldR RSsRVdI5vDNVKRkG215avwFG7YkRkhgiOKjMs6JCiLa8c4ISk7E3jPX7y8sHlMN4jAL8 TWCpnBXT5GX5pKJ9fjnx04c5PTszvRt19+db/kcumpL9uK2dOgKdAULVzZO5oEuNUtv6 76TQpJlOz3vor9qG7jqL4F/YS9UoPpg0yoOU2/SN20o18YlTnRBCSlxqfxpdxkeOwiVZ w1vA== X-Gm-Message-State: AGi0PuamNtmFAe8X6kTTG/Xsfdolvh4CVGf+J/2+i/USFvhadPnf7Eib NmxNPD33UnrCAeniVBS3glJeOgjBb43wpg== X-Google-Smtp-Source: APiQypLv85/ivbA+DcFrwvD4zHlx16bJI6Zu4b9MTnY51aBljq0lYBh1Gg7Hao613nl9Rg4XGDGzhQ== X-Received: by 2002:a05:6214:173:: with SMTP id y19mr11502093qvs.106.1587061268006; Thu, 16 Apr 2020 11:21:08 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id s15sm16363679qtc.31.2020.04.16.11.21.07 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Apr 2020 11:21:07 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jP98M-0006MB-Uj; Thu, 16 Apr 2020 15:21:06 -0300 Date: Thu, 16 Apr 2020 15:21:06 -0300 From: Jason Gunthorpe To: Nicolas Pitre Cc: Arnd Bergmann , Jani Nikula , Saeed Mahameed , "narmstrong@baylibre.com" , "masahiroy@kernel.org" , "Laurent.pinchart@ideasonboard.com" , "leon@kernel.org" , "davem@davemloft.net" , "linux-renesas-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "kieran.bingham+renesas@ideasonboard.com" , "a.hajda@samsung.com" , "jonas@kwiboo.se" , "netdev@vger.kernel.org" , "airlied@linux.ie" , "jernej.skrabec@siol.net" Subject: Re: [RFC 0/6] Regressions for "imply" behavior change Message-ID: <20200416182106.GX5100@ziepe.ca> References: <20200414152312.GF5100@ziepe.ca> <834c7606743424c64951dd2193ca15e29799bf18.camel@mellanox.com> <874ktj4tvn.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 16, 2020 at 11:12:56AM -0400, Nicolas Pitre wrote: > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > > On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula > > wrote: > > > > > > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > > > On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed wrote: > > > >> BTW how about adding a new Kconfig option to hide the details of > > > >> ( BAR || !BAR) ? as Jason already explained and suggested, this will > > > >> make it easier for the users and developers to understand the actual > > > >> meaning behind this tristate weird condition. > > > >> > > > >> e.g have a new keyword: > > > >> reach VXLAN > > > >> which will be equivalent to: > > > >> depends on VXLAN && !VXLAN > > > > > > > > I'd love to see that, but I'm not sure what keyword is best. For your > > > > suggestion of "reach", that would probably do the job, but I'm not > > > > sure if this ends up being more or less confusing than what we have > > > > today. > > > > > > Ah, perfect bikeshedding topic! > > > > > > Perhaps "uses"? If the dependency is enabled it gets used as a > > > dependency. > > > > That seems to be the best naming suggestion so far > > What I don't like about "uses" is that it doesn't convey the conditional > dependency. It could be mistaken as being synonymous to "select". > > What about "depends_if" ? The rationale is that this is actually a > dependency, but only if the related symbol is set (i.e. not n or empty). I think that stretches the common understanding of 'depends' a bit too far.. A depends where the target can be N is just too strange. Somthing incorporating 'optional' seems like a better choice 'optionally uses' seems particularly clear and doesn't overload existing works like depends or select Jason