From: Andreas Kemnade <andreas@kemnade.info>
To: Tony Lindgren <tony@atomide.com>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
Evgeniy Polyakov <zbr@ioremap.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Adam Ford <aford173@gmail.com>, "Andrew F . Davis" <afd@ti.com>,
Vignesh R <vigneshr@ti.com>
Subject: Re: [PATCHv3] w1: omap-hdq: Simplify driver with PM runtime autosuspend
Date: Thu, 16 Apr 2020 22:04:49 +0200 [thread overview]
Message-ID: <20200416220449.17068b21@aktux> (raw)
In-Reply-To: <20200416184638.GI37466@atomide.com>
On Thu, 16 Apr 2020 11:46:38 -0700
Tony Lindgren <tony@atomide.com> wrote:
> * H. Nikolaus Schaller <hns@goldelico.com> [200416 15:04]:
> > Hi Tony,
> > it looks as if something with this patch is broken on GTA04. For v5.6 and v5.7-rc1.
> >
> > HDQ battery access times out after ca. 15 seconds and I get temperature of -273.1°C...
> >
> > Reverting this patch and everything is ok again.
>
> Hmm OK interesting.
>
> > What is "ti,mode" about? Do we have that (indirectly) in gta04.dtsi?
> > Or does this patch need some CONFIGs we do not happen to have?
>
> Sounds like you have things working though so there should be no
> need for having ti,mode = "1w" in the dts.
>
> > > pm_runtime_enable(&pdev->dev);
> > > + pm_runtime_use_autosuspend(&pdev->dev);
> > > + pm_runtime_set_autosuspend_delay(&pdev->dev, 300);
>
> Care to check if changing pm_runtime_set_autosuspend_delay value
> to -1 in probe makes the issue go away? Or change it manually
> to -1 via sysfs.
>
> If that helps, likely we have a missing pm_runtime_get_sync()
> somewhere in the driver.
>
I have not tested yet with v5.7-rc1 (it is compiling right now),
but I have not seen any problems with init=/bin/bash on v5.6
and only a minimal set of modules loaded on gta04. I have seen that
42 for IDLEST
So might be something a bit more weird.
Regards,
Andreas
next prev parent reply other threads:[~2020-04-16 20:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 0:40 [PATCHv3] w1: omap-hdq: Simplify driver with PM runtime autosuspend Tony Lindgren
2020-04-16 15:02 ` H. Nikolaus Schaller
2020-04-16 18:46 ` Tony Lindgren
2020-04-16 20:04 ` Andreas Kemnade [this message]
2020-04-16 20:33 ` Tony Lindgren
2020-04-17 14:21 ` H. Nikolaus Schaller
2020-04-17 14:22 ` H. Nikolaus Schaller
2020-04-17 14:43 ` Andreas Kemnade
2020-04-17 14:52 ` H. Nikolaus Schaller
2020-04-17 15:07 ` Tony Lindgren
2020-04-17 15:14 ` Tony Lindgren
2020-04-17 15:36 ` Andreas Kemnade
2020-04-17 21:03 ` H. Nikolaus Schaller
2020-04-20 15:08 ` Tony Lindgren
2020-04-20 21:11 ` H. Nikolaus Schaller
2020-04-21 6:53 ` Andreas Kemnade
2020-04-21 18:02 ` Tony Lindgren
2020-04-21 18:13 ` H. Nikolaus Schaller
2020-04-21 18:20 ` Tony Lindgren
2020-04-21 18:24 ` Andreas Kemnade
2020-04-21 20:40 ` H. Nikolaus Schaller
2020-04-22 10:04 ` Andreas Kemnade
2020-04-22 16:06 ` H. Nikolaus Schaller
[not found] ` <A2AC3E81-49B2-4CF2-A7CF-6075AEB1B72D@goldelico.com>
2020-04-25 10:29 ` H. Nikolaus Schaller
2020-04-25 10:37 ` H. Nikolaus Schaller
2020-04-29 21:34 ` H. Nikolaus Schaller
2020-04-29 21:38 ` Tony Lindgren
2020-05-09 11:47 ` H. Nikolaus Schaller
2020-05-09 13:59 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416220449.17068b21@aktux \
--to=andreas@kemnade.info \
--cc=afd@ti.com \
--cc=aford173@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).