linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] soc: qcom: cmd-db: Properly endian swap the slv_id for debugfs
@ 2020-04-17  0:06 Stephen Boyd
  2020-04-17 14:05 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Boyd @ 2020-04-17  0:06 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson
  Cc: linux-kernel, linux-arm-msm, kbuild test robot, Lina Iyer

Read the slv_id properly by making sure the 16-bit number is endian
swapped from little endian to CPU native before we read it to figure out
what to print for the human readable name. Otherwise we may just show
that all the elements in the cmd-db are "Unknown" which isn't right.

Reported-by: kbuild test robot <lkp@intel.com>
Cc: Lina Iyer <ilina@codeaurora.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 drivers/soc/qcom/cmd-db.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
index 4f8b739c6485..fc5610603b17 100644
--- a/drivers/soc/qcom/cmd-db.c
+++ b/drivers/soc/qcom/cmd-db.c
@@ -254,7 +254,7 @@ static int cmd_db_debugfs_dump(struct seq_file *seq, void *p)
 		if (!rsc->slv_id)
 			break;
 
-		switch (rsc->slv_id) {
+		switch (le16_to_cpu(rsc->slv_id)) {
 		case CMD_DB_HW_ARC:
 			name = "ARC";
 			break;

base-commit: d6815c5c43d4f9d18e557d27fd27ae8d9cfd450c
prerequisite-patch-id: fc235b174200bb1b24876628a89a841d1c2e4aad
prerequisite-patch-id: df579afb4eaea4200733d9dffb1d75eef8d8360b
-- 
Sent by a computer, using git, on the internet


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] soc: qcom: cmd-db: Properly endian swap the slv_id for debugfs
  2020-04-17  0:06 [PATCH] soc: qcom: cmd-db: Properly endian swap the slv_id for debugfs Stephen Boyd
@ 2020-04-17 14:05 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-04-17 14:05 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: Andy Gross, Bjorn Andersson, linux-kernel, linux-arm-msm,
	kbuild test robot, Lina Iyer

On Thu, Apr 16, 2020 at 05:06:45PM -0700, Stephen Boyd wrote:
> Read the slv_id properly by making sure the 16-bit number is endian
> swapped from little endian to CPU native before we read it to figure out
> what to print for the human readable name. Otherwise we may just show
> that all the elements in the cmd-db are "Unknown" which isn't right.
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Cc: Lina Iyer <ilina@codeaurora.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/soc/qcom/cmd-db.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> base-commit: d6815c5c43d4f9d18e557d27fd27ae8d9cfd450c
> prerequisite-patch-id: fc235b174200bb1b24876628a89a841d1c2e4aad
> prerequisite-patch-id: df579afb4eaea4200733d9dffb1d75eef8d8360b
> 
> diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
> index 4f8b739c6485..fc5610603b17 100644
> --- a/drivers/soc/qcom/cmd-db.c
> +++ b/drivers/soc/qcom/cmd-db.c
> @@ -254,7 +254,7 @@ static int cmd_db_debugfs_dump(struct seq_file *seq, void *p)
>  		if (!rsc->slv_id)
>  			break;
>  
> -		switch (rsc->slv_id) {
> +		switch (le16_to_cpu(rsc->slv_id)) {
>  		case CMD_DB_HW_ARC:
>  			name = "ARC";
>  			break;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-17 14:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17  0:06 [PATCH] soc: qcom: cmd-db: Properly endian swap the slv_id for debugfs Stephen Boyd
2020-04-17 14:05 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).