From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5CA4C2BB55 for ; Fri, 17 Apr 2020 08:46:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFCEB20656 for ; Fri, 17 Apr 2020 08:46:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OBjTYKGS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729912AbgDQIqT (ORCPT ); Fri, 17 Apr 2020 04:46:19 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:34249 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729809AbgDQIqR (ORCPT ); Fri, 17 Apr 2020 04:46:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587113176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wE/WARZLg+d1WCxCwrHkOlSrWaAPnJuSBoxihd1UamI=; b=OBjTYKGSJAINHUfpR4calOLk+SvqbiTWr+tY+zs3pzY5Flwpjk4cqBuG2x3aiRD4IVNhzg dgqkfbn78l8hQEDDtCqLGyUN8+JPgq40klBBZ+xA0bHUJ1Ay+H7bhk+j1ZQtjvwM5naDj/ 2Ids74giy7NIe+3J7I39Cr7UrcIDp5I= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-483-NRan9ghfPxqLuUVOsMsmeg-1; Fri, 17 Apr 2020 04:46:15 -0400 X-MC-Unique: NRan9ghfPxqLuUVOsMsmeg-1 Received: by mail-wr1-f69.google.com with SMTP id 11so664434wrc.3 for ; Fri, 17 Apr 2020 01:46:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wE/WARZLg+d1WCxCwrHkOlSrWaAPnJuSBoxihd1UamI=; b=NRjLOn1KegWeU4ttQesDbKAlpF5gpK0gmcmk00CpSsirIggpMaGomDaNqTDvvDoXhV ollZ+UJ4A4cwPhIZPAg+VooRxcAwcDyblmgFKRtXY9RufD8Bjs9ikPvSy4oArE3iEVuj HqlANenaLW7X2u/tK34IZo4tM8buCnqzeeYUA8d8/DuXoFsxvk9F6mvtAArvvMdU/qYN VeweI+StXOKOo3xG+vrT5cwT7IHBcTrdQV3NqhnPIG1J8HXEhorqDacLwb5o+ke+W4W8 109nolXKCxAF/xSPcQTJvjiMtHdpm5IiUnQEqdtXWmjgPaknavqHfJ+TwHRnV1zv/x3E +0Ng== X-Gm-Message-State: AGi0PuZf4Dlqg5U5l7z9Rxcw1Qkb73IFKtfuFoz3xPx7hh6yMxzDGrZz DIn6CV6yVgS1tQPrDopqozMBwhmPsw4EHGYLbMeKSCMopbw73sIZLZAac6VuVEVcBJjzH67H4xc XkLZ5iTRjmhyCZYet3r8+bupv X-Received: by 2002:a1c:3b0a:: with SMTP id i10mr2207020wma.26.1587113173864; Fri, 17 Apr 2020 01:46:13 -0700 (PDT) X-Google-Smtp-Source: APiQypL7wwVAY2VUk1Sf/olefVQONEzwVRmuwANF/2eIBwUJQiUqpjYTnQ3meLl2WX6+2mTArW0sHw== X-Received: by 2002:a1c:3b0a:: with SMTP id i10mr2206989wma.26.1587113173640; Fri, 17 Apr 2020 01:46:13 -0700 (PDT) Received: from redhat.com (bzq-79-183-51-3.red.bezeqint.net. [79.183.51.3]) by smtp.gmail.com with ESMTPSA id l5sm31065502wrm.66.2020.04.17.01.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2020 01:46:13 -0700 (PDT) Date: Fri, 17 Apr 2020 04:46:08 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, geert@linux-m68k.org, tsbogend@alpha.franken.de, benh@kernel.crashing.org, paulus@samba.org, heiko.carstens@de.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, Michael Ellerman Subject: Re: [PATCH V2] vhost: do not enable VHOST_MENU by default Message-ID: <20200417044230-mutt-send-email-mst@kernel.org> References: <20200415024356.23751-1-jasowang@redhat.com> <20200416185426-mutt-send-email-mst@kernel.org> <20200417022929-mutt-send-email-mst@kernel.org> <4274625d-6feb-81b6-5b0a-695229e7c33d@redhat.com> <20200417042912-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 17, 2020 at 04:39:49PM +0800, Jason Wang wrote: > > On 2020/4/17 下午4:29, Michael S. Tsirkin wrote: > > On Fri, Apr 17, 2020 at 03:36:52PM +0800, Jason Wang wrote: > > > On 2020/4/17 下午2:33, Michael S. Tsirkin wrote: > > > > On Fri, Apr 17, 2020 at 11:12:14AM +0800, Jason Wang wrote: > > > > > On 2020/4/17 上午6:55, Michael S. Tsirkin wrote: > > > > > > On Wed, Apr 15, 2020 at 10:43:56AM +0800, Jason Wang wrote: > > > > > > > We try to keep the defconfig untouched after decoupling CONFIG_VHOST > > > > > > > out of CONFIG_VIRTUALIZATION in commit 20c384f1ea1a > > > > > > > ("vhost: refine vhost and vringh kconfig") by enabling VHOST_MENU by > > > > > > > default. Then the defconfigs can keep enabling CONFIG_VHOST_NET > > > > > > > without the caring of CONFIG_VHOST. > > > > > > > > > > > > > > But this will leave a "CONFIG_VHOST_MENU=y" in all defconfigs and even > > > > > > > for the ones that doesn't want vhost. So it actually shifts the > > > > > > > burdens to the maintainers of all other to add "CONFIG_VHOST_MENU is > > > > > > > not set". So this patch tries to enable CONFIG_VHOST explicitly in > > > > > > > defconfigs that enables CONFIG_VHOST_NET and CONFIG_VHOST_VSOCK. > > > > > > > > > > > > > > Acked-by: Christian Borntraeger (s390) > > > > > > > Acked-by: Michael Ellerman (powerpc) > > > > > > > Cc: Thomas Bogendoerfer > > > > > > > Cc: Benjamin Herrenschmidt > > > > > > > Cc: Paul Mackerras > > > > > > > Cc: Michael Ellerman > > > > > > > Cc: Heiko Carstens > > > > > > > Cc: Vasily Gorbik > > > > > > > Cc: Christian Borntraeger > > > > > > > Reported-by: Geert Uytterhoeven > > > > > > > Signed-off-by: Jason Wang > > > > > > I rebased this on top of OABI fix since that > > > > > > seems more orgent to fix. > > > > > > Pushed to my vhost branch pls take a look and > > > > > > if possible test. > > > > > > Thanks! > > > > > I test this patch by generating the defconfigs that wants vhost_net or > > > > > vhost_vsock. All looks fine. > > > > > > > > > > But having CONFIG_VHOST_DPN=y may end up with the similar situation that > > > > > this patch want to address. > > > > > Maybe we can let CONFIG_VHOST depends on !ARM || AEABI then add another > > > > > menuconfig for VHOST_RING and do something similar? > > > > > > > > > > Thanks > > > > Sorry I don't understand. After this patch CONFIG_VHOST_DPN is just > > > > an internal variable for the OABI fix. I kept it separate > > > > so it's easy to revert for 5.8. Yes we could squash it into > > > > VHOST directly but I don't see how that changes logic at all. > > > > > > Sorry for being unclear. > > > > > > I meant since it was enabled by default, "CONFIG_VHOST_DPN=y" will be left > > > in the defconfigs. > > But who cares? > > > FYI, please see https://www.spinics.net/lists/kvm/msg212685.html The complaint was not about the symbol IIUC. It was that we caused everyone to build vhost unless they manually disabled it. > > > That does not add any code, does it? > > > It doesn't. > > Thanks > > > > > > > This requires the arch maintainers to add > > > "CONFIG_VHOST_VDPN is not set". (Geert complains about this) > > > > > > Thanks > > > > > >