* Re: [PATCH] samples/hw_breakpoint: make sample_hbp static
2020-04-17 7:35 [PATCH] samples/hw_breakpoint: make sample_hbp static Jason Yan
@ 2020-04-17 7:31 ` Will Deacon
0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2020-04-17 7:31 UTC (permalink / raw)
To: Jason Yan; +Cc: tglx, linux-kernel, Hulk Robot
On Fri, Apr 17, 2020 at 03:35:42PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
>
> samples/hw_breakpoint/data_breakpoint.c:24:19: warning: symbol
> 'sample_hbp' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> samples/hw_breakpoint/data_breakpoint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/hw_breakpoint/data_breakpoint.c b/samples/hw_breakpoint/data_breakpoint.c
> index 418c46fe5ffc..37c4f0ea8e53 100644
> --- a/samples/hw_breakpoint/data_breakpoint.c
> +++ b/samples/hw_breakpoint/data_breakpoint.c
> @@ -21,7 +21,7 @@
> #include <linux/perf_event.h>
> #include <linux/hw_breakpoint.h>
>
> -struct perf_event * __percpu *sample_hbp;
> +static struct perf_event * __percpu *sample_hbp;
>
> static char ksym_name[KSYM_NAME_LEN] = "jiffies";
> module_param_string(ksym, ksym_name, KSYM_NAME_LEN, S_IRUGO);
Acked-by: Will Deacon <will@kernel.org>
Will
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] samples/hw_breakpoint: make sample_hbp static
@ 2020-04-17 7:35 Jason Yan
2020-04-17 7:31 ` Will Deacon
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-17 7:35 UTC (permalink / raw)
To: will, tglx, linux-kernel; +Cc: Jason Yan, Hulk Robot
Fix the following sparse warning:
samples/hw_breakpoint/data_breakpoint.c:24:19: warning: symbol
'sample_hbp' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
samples/hw_breakpoint/data_breakpoint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/hw_breakpoint/data_breakpoint.c b/samples/hw_breakpoint/data_breakpoint.c
index 418c46fe5ffc..37c4f0ea8e53 100644
--- a/samples/hw_breakpoint/data_breakpoint.c
+++ b/samples/hw_breakpoint/data_breakpoint.c
@@ -21,7 +21,7 @@
#include <linux/perf_event.h>
#include <linux/hw_breakpoint.h>
-struct perf_event * __percpu *sample_hbp;
+static struct perf_event * __percpu *sample_hbp;
static char ksym_name[KSYM_NAME_LEN] = "jiffies";
module_param_string(ksym, ksym_name, KSYM_NAME_LEN, S_IRUGO);
--
2.21.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-17 7:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 7:35 [PATCH] samples/hw_breakpoint: make sample_hbp static Jason Yan
2020-04-17 7:31 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).