From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D47E2C352BE for ; Fri, 17 Apr 2020 09:08:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA2E4207FC for ; Fri, 17 Apr 2020 09:08:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730142AbgDQJIG (ORCPT ); Fri, 17 Apr 2020 05:08:06 -0400 Received: from mga06.intel.com ([134.134.136.31]:63669 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729920AbgDQJIG (ORCPT ); Fri, 17 Apr 2020 05:08:06 -0400 IronPort-SDR: 2MPfzQptYq8LiUN6kNNXHRbzpc5vW3YXr06vT86ngSqGe8APKcD4ZgaQXlU8yPaNzVcU+msbiB /8JJOCYyC70w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2020 02:08:05 -0700 IronPort-SDR: jvMrM+Wg0TzZleKwbmoq0OBHeWB9RDLsiHFsRIDtB3wYf3jYPSBKF26C//gewkVl9dNEOF8sqa jyluc0XR7GNg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,394,1580803200"; d="scan'208";a="364275831" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 17 Apr 2020 02:08:00 -0700 Received: by lahna (sSMTP sendmail emulation); Fri, 17 Apr 2020 12:07:59 +0300 Date: Fri, 17 Apr 2020 12:07:59 +0300 From: Mika Westerberg To: "Ronald G. Minnich" Cc: "Ronald G. Minnich" , Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Boris Brezillon , Jethro Beekman , Enrico Weigelt , Thomas Gleixner , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: spi-nor: add cmdlineparts to intel-spi Message-ID: <20200417090759.GN2586@lahna.fi.intel.com> References: <20200416162830.183725-1-rminnich@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416162830.183725-1-rminnich@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 16, 2020 at 09:28:28AM -0700, Ronald G. Minnich wrote: > On Intel platforms, the usable SPI area is located several > MiB in from the start, to leave room for descriptors and > the Management Engine binary. Further, not all the remaining > space can be used, as the last 16 MiB contains firmware. > > To make the SPI usable for mtdblock and other devices, > it is necessary to enable command line partitions so the > middle usable region can be specified. > > Add a part_probes array which includes only "cmdelineparts", > and change to mtd_device_parse_register to use this part_probes. > > Signed-off-by: Ronald G. Minnich I guess the $subject should be something like: mtd: spi-nor: controllers: intel-spi: Add support for command line partitions The patch itself looks good to me, Reviewed-by: Mika Westerberg