From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EB60C38A29 for ; Fri, 17 Apr 2020 10:20:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5948A208E4 for ; Fri, 17 Apr 2020 10:20:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="q6vYtPsi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728861AbgDQKTw (ORCPT ); Fri, 17 Apr 2020 06:19:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728144AbgDQKT1 (ORCPT ); Fri, 17 Apr 2020 06:19:27 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEE93C061A0F for ; Fri, 17 Apr 2020 03:19:25 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id w11so884454pga.12 for ; Fri, 17 Apr 2020 03:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Ty9TQTjWvzY6Grz85/BgM3W5FIy2Fq6407pZyTtwzbI=; b=q6vYtPsi279r4gZwjmK0lADCWk83Aw27TpjFuR486x9Fg/jSQQlsq/M2M5DT8I1i6A GP2CaI4PxrPfnJh9JKKc/O/0F74VEavRqOkopFpywlIc4bYY2CeWisrFDsZaugLcONKb cTM0F5iqpKJA+DvX58EfjOfUimrYmh6HTTOxVMc9ETn9ERuDhiAU3XvVrxnKJnQjxOj+ khU8tqSMb6T+kXPhUVClXoCdJmWKtkq4sjlivMoymuKYDBi3B0AKFGYDYGaqRLqCyATS /4juFM6A1gSeluMNtix0QqAjV8xLmJh8aQT4ujp6BOcwFHNJRor/q0MIGWZx+C1FqY6D IyQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Ty9TQTjWvzY6Grz85/BgM3W5FIy2Fq6407pZyTtwzbI=; b=NpxWhrOMFQy5XtAcwXJtEcpARsbJ1QBqLVwK2XvpD7cKaN+GsPZy5EfhnI7TrUQDmd Xtps2vTMsQQ+43yQKQYc+y4pyMThTkPTs1a/16o3vM0hsJOXvWu0I6wie8Md/j8MzAUV bRulYdG2hvC0U8zxFG4neubjtwYf/Q1lJLW35y56il5oP8aSvyJSh5TpjKpZ4TyZ1QWJ 2uyyTNx7gJYHrQQwC8mNcn7GaNTNaTZYspAb2S2Uq2raMzhadn+nGzTFl6LkIwbCr6Cd w1yXVRieoDYZS3cSgKDzIMOr2mvd9LvwZBGI4YVzbFJmFx3hafeESbX3u8sNICs4abYQ WNNw== X-Gm-Message-State: AGi0PuZ0hOKtUTjofjdIryHwlhST7IB8yhZHXD5Zc/iMGJwAP4ZSEIfq yuGBTOmoWOGOe9aTQR4MUTm9 X-Google-Smtp-Source: APiQypLivRS+jr84KCVU43CbZvx9g2aVlPNj8F7+dQWJd7s2CaFzd1iu/pT3ZiHkUrXBKLVSSTbH4Q== X-Received: by 2002:a63:d742:: with SMTP id w2mr2129826pgi.401.1587118765122; Fri, 17 Apr 2020 03:19:25 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:630d:b86f:218c:c3f8:1490:7b19]) by smtp.gmail.com with ESMTPSA id x25sm17011580pfm.203.2020.04.17.03.19.21 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Apr 2020 03:19:24 -0700 (PDT) Date: Fri, 17 Apr 2020 15:49:18 +0530 From: Manivannan Sadhasivam To: Hemant Kumar Cc: jhugo@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, smohanad@codeaurora.org, dan.carpenter@oracle.com Subject: Re: [PATCH 1/2] bus: mhi: core: Fix parsing of mhi_flags Message-ID: <20200417101918.GB10295@Mani-XPS-13-9360> References: <20200413120741.2832-1-manivannan.sadhasivam@linaro.org> <73d4815e-af00-e4cd-95c5-5043d334224c@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <73d4815e-af00-e4cd-95c5-5043d334224c@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 16, 2020 at 12:01:30PM -0700, Hemant Kumar wrote: > Hi Mani, > > On 4/13/20 5:07 AM, Manivannan Sadhasivam wrote: > > With the current parsing of mhi_flags, the following statement always > > return false: > > > > eob = !!(flags & MHI_EOB); > > > > This is due to the fact that 'enum mhi_flags' starts with index 0 and we > > are using direct AND operation to extract each bit. Fix this by using > > BIT() macro to extract each bit and make the mhi_flags index start from 1. > > > > Fixes: 189ff97cca53 ("bus: mhi: core: Add support for data transfer") > > Reported-by: Dan Carpenter > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/bus/mhi/core/main.c | 6 +++--- > > include/linux/mhi.h | 2 +- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > > index eb4256b81406..4165a853c189 100644 > > --- a/drivers/bus/mhi/core/main.c > > +++ b/drivers/bus/mhi/core/main.c > > @@ -1090,9 +1090,9 @@ int mhi_gen_tre(struct mhi_controller *mhi_cntrl, struct mhi_chan *mhi_chan, > > if (ret) > > return ret; > > - eob = !!(flags & MHI_EOB); > > - eot = !!(flags & MHI_EOT); > > - chain = !!(flags & MHI_CHAIN); > > + eob = !!(flags & BIT(0)); > > + eot = !!(flags & BIT(1)); > > + chain = !!(flags & BIT(2)); > > How about setting enums  with BIT macro and still use same enums above. If > flags is having MHI _CHAIN (enum value 3) but comparing with BIT(2) (value > 4) will not work. > Doh, you are right. Will fix it! Thanks, Mani > > bei = !!(mhi_chan->intmod); > > mhi_tre = tre_ring->wp; > > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > > index ad1996001965..22185fecbbf2 100644 > > --- a/include/linux/mhi.h > > +++ b/include/linux/mhi.h > > @@ -53,7 +53,7 @@ enum mhi_callback { > > * @MHI_CHAIN: Linked transfer > > */ > > enum mhi_flags { > > - MHI_EOB, > > + MHI_EOB = 1, > > MHI_EOT, > > MHI_CHAIN, > > }; > > enum mhi_flags { > >     MHI_EOB = BIT(0), > >     MHI_EOT = BIT(1), > >     MHI_CHAIN = BIT(2), > > } > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project