From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E279C2D0EF for ; Fri, 17 Apr 2020 17:05:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 052DF20771 for ; Fri, 17 Apr 2020 17:05:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728421AbgDQRFP (ORCPT ); Fri, 17 Apr 2020 13:05:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727913AbgDQRFO (ORCPT ); Fri, 17 Apr 2020 13:05:14 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF4F1C061A0C for ; Fri, 17 Apr 2020 10:05:14 -0700 (PDT) Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1jPUQM-0003TL-Qf; Fri, 17 Apr 2020 19:05:06 +0200 Date: Fri, 17 Apr 2020 19:05:06 +0200 From: Sebastian Andrzej Siewior To: Kaitao Cheng Cc: tglx@linutronix.de, peterz@infradead.org, namit@vmware.com, linux-kernel@vger.kernel.org, songmuchun@bytedance.com Subject: Re: [PATCH RESEND] kernel/smp: Use smp_call_func_t in on_each_cpu() Message-ID: <20200417170506.ldz2eee4mm4szqij@linutronix.de> References: <20200417162451.91969-1-pilgrimtao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200417162451.91969-1-pilgrimtao@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-04-18 00:24:51 [+0800], Kaitao Cheng wrote: > There is already a typedef smp_call_func_t, so we can just use it, > maybe better. > > Fixes: 3a5f65df5a0fc ("Typedef SMP call function pointer") > Signed-off-by: Kaitao Cheng I would not go as far as the Fixes: tag but otherwise: Acked-by: Sebastian Andrzej Siewior > --- > kernel/smp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/smp.c b/kernel/smp.c > index 786092aabdcd..84303197caf9 100644 > --- a/kernel/smp.c > +++ b/kernel/smp.c > @@ -620,7 +620,7 @@ void __init smp_init(void) > * early_boot_irqs_disabled is set. Use local_irq_save/restore() instead > * of local_irq_disable/enable(). > */ > -void on_each_cpu(void (*func) (void *info), void *info, int wait) > +void on_each_cpu(smp_call_func_t func, void *info, int wait) > { > unsigned long flags; > Sebastian