From: "Luck, Tony" <tony.luck@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>, Fenghua Yu <fenghua.yu@intel.com>,
Borislav Petkov <bp@alien8.de>, H Peter Anvin <hpa@zytor.com>,
Ashok Raj <ashok.raj@intel.com>,
Ravi V Shankar <ravi.v.shankar@intel.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Andy Lutomirski <luto@kernel.org>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 2/3] x86/split_lock: Bits in IA32_CORE_CAPABILITIES are not architectural
Date: Fri, 17 Apr 2020 12:56:01 -0700 [thread overview]
Message-ID: <20200417195601.GA22640@agluck-desk2.amr.corp.intel.com> (raw)
In-Reply-To: <87ftd1zzau.fsf@nanos.tec.linutronix.de>
On Fri, Apr 17, 2020 at 09:29:13PM +0200, Thomas Gleixner wrote:
> "Luck, Tony" <tony.luck@intel.com> writes:
> > On Fri, Apr 17, 2020 at 12:04:36PM +0200, Thomas Gleixner wrote:
> > + if (!m->driver_data)
> > + goto setup;
> > + if (!cpu_has(c, X86_FEATURE_CORE_CAPABILITIES))
> > + return;
> > + rdmsrl(MSR_IA32_CORE_CAPS, ia32_core_caps);
> > + if (!(ia32_core_caps & MSR_IA32_CORE_CAPS_SPLIT_LOCK_DETECT))
> > + return;
> > +setup:
> > + split_lock_setup();
>
> Which looks nicer w/o the goto:
>
> if (m->driver_data) {
> if (!cpu_has(c, X86_FEATURE_CORE_CAPABILITIES))
> return;
> rdmsrl(MSR_IA32_CORE_CAPS, ia32_core_caps);
> if (!(ia32_core_caps & MSR_IA32_CORE_CAPS_SPLIT_LOCK_DETECT))
> return;
> }
>
> Hmm?
Swings and roundabouts ... getting rid of the goto makes for
deeper indentation. But if you really want to get rid of the
goto, then your version is fine with me.
Do you want me to spin it into v3?
-Tony
next prev parent reply other threads:[~2020-04-17 19:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 20:57 [PATCH 0/3] Split lock enumeration cleanup and fixes Tony Luck
2020-04-16 20:57 ` [PATCH 1/3] x86/split_lock: Update to use X86_MATCH_INTEL_FAM6_MODEL() Tony Luck
2020-04-17 10:20 ` [tip: x86/urgent] " tip-bot2 for Tony Luck
2020-04-16 20:57 ` [PATCH 2/3] x86/split_lock: Bits in IA32_CORE_CAPABILITIES are not architectural Tony Luck
2020-04-16 22:06 ` Thomas Gleixner
2020-04-16 22:33 ` Luck, Tony
2020-04-17 9:48 ` Thomas Gleixner
2020-04-17 10:04 ` Thomas Gleixner
2020-04-17 17:06 ` Luck, Tony
2020-04-17 19:29 ` Thomas Gleixner
2020-04-17 19:56 ` Luck, Tony [this message]
2020-04-17 20:48 ` Thomas Gleixner
2020-04-17 21:07 ` Thomas Gleixner
2020-04-17 21:19 ` Luck, Tony
2020-04-17 22:18 ` Thomas Gleixner
2020-04-18 4:15 ` Xiaoyao Li
2020-04-18 4:35 ` Sean Christopherson
2020-04-18 9:27 ` Thomas Gleixner
2020-04-18 10:54 ` [tip: x86/urgent] " tip-bot2 for Tony Luck
2020-04-16 20:57 ` [PATCH 3/3] x86/split_lock: Add Tremont family CPU models Tony Luck
2020-04-18 10:54 ` [tip: x86/urgent] " tip-bot2 for Tony Luck
2020-04-16 21:35 ` [PATCH 0/3] Split lock enumeration cleanup and fixes Thomas Gleixner
2020-04-16 21:39 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417195601.GA22640@agluck-desk2.amr.corp.intel.com \
--to=tony.luck@intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).