From: Matthias Kaehlcke <mka@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: bjorn.andersson@linaro.org, agross@kernel.org,
swboyd@chromium.org, mkshah@codeaurora.org,
Evan Green <evgreen@chromium.org>,
Srinivas Rao L <lsrao@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: rpmh: Dirt can only make you dirtier, not cleaner
Date: Sat, 18 Apr 2020 09:15:57 -0700 [thread overview]
Message-ID: <20200418161557.GF199755@google.com> (raw)
In-Reply-To: <20200417141531.1.Ia4b74158497213eabad7c3d474c50bfccb3f342e@changeid>
On Fri, Apr 17, 2020 at 02:15:47PM -0700, Douglas Anderson wrote:
> Adding an item into the cache should never be able to make the cache
> cleaner. Use "|=" rather than "=" to update the dirty flag.
>
> Fixes: bb7000677a1b ("soc: qcom: rpmh: Update dirty flag only when data changes")
> Reported-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/soc/qcom/rpmh.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c
> index 3abbb08cd6e1..d1626a1328d7 100644
> --- a/drivers/soc/qcom/rpmh.c
> +++ b/drivers/soc/qcom/rpmh.c
> @@ -151,10 +151,10 @@ static struct cache_req *cache_rpm_request(struct rpmh_ctrlr *ctrlr,
> break;
> }
>
> - ctrlr->dirty = (req->sleep_val != old_sleep_val ||
> - req->wake_val != old_wake_val) &&
> - req->sleep_val != UINT_MAX &&
> - req->wake_val != UINT_MAX;
> + ctrlr->dirty |= (req->sleep_val != old_sleep_val ||
> + req->wake_val != old_wake_val) &&
> + req->sleep_val != UINT_MAX &&
> + req->wake_val != UINT_MAX;
>
> unlock:
> spin_unlock_irqrestore(&ctrlr->cache_lock, flags);
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2020-04-18 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 21:15 [PATCH] soc: qcom: rpmh: Dirt can only make you dirtier, not cleaner Douglas Anderson
2020-04-18 16:15 ` Matthias Kaehlcke [this message]
2020-04-20 20:31 ` Bjorn Andersson
2020-04-20 20:47 ` Doug Anderson
2020-04-21 6:57 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200418161557.GF199755@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsrao@codeaurora.org \
--cc=mkshah@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).