From: Philip Li <philip.li@intel.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: kbuild test robot <lkp@intel.com>,
Jonathan Cameron <jic23@kernel.org>,
kbuild-all@lists.01.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] iio: adc: ti-ads8344: properly byte swap value
Date: Sun, 19 Apr 2020 10:49:48 +0800 [thread overview]
Message-ID: <20200419024948.GK21730@intel.com> (raw)
In-Reply-To: <20200416205023.GA437042@piout.net>
On Thu, Apr 16, 2020 at 10:50:23PM +0200, Alexandre Belloni wrote:
> Hi,
>
> On 16/04/2020 14:22:03+0800, kbuild test robot wrote:
> > Hi Alexandre,
> >
> > I love your patch! Yet something to improve:
> >
> > [auto build test ERROR on iio/togreg]
> > [also build test ERROR on v5.7-rc1 next-20200415]
> > [if your patch is applied to the wrong git tree, please drop us a note to help
> > improve the system. BTW, we also suggest to use '--base' option to specify the
> > base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> >
> > url: https://github.com/0day-ci/linux/commits/Alexandre-Belloni/iio-adc-ti-ads8344-improve-the-driver/20200416-073357
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> > config: c6x-allyesconfig (attached as .config)
> > compiler: c6x-elf-gcc (GCC) 9.3.0
> > reproduce:
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=c6x
> >
>
> I spent some time to reproduce and this is actually not that trivial
> because your toolchains are linked with libisl22 and most distributions
> still ship an older version. Maybe you can do something about that?
Thanks for the feedback, we will resolve this to use old version in
earliest time.
>
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> >
> > vim +/302 +96 drivers/iio/adc/ti-ads8344.c
> >
> > 72
> > 73 static int ads8344_adc_conversion(struct ads8344 *adc, int channel,
> > 74 bool differential)
> > 75 {
> > 76 struct spi_device *spi = adc->spi;
> > 77 int ret;
> > 78 u8 buf[3];
> > 79
> > 80 adc->tx_buf = ADS8344_START;
> > 81 if (!differential)
> > 82 adc->tx_buf |= ADS8344_SINGLE_END;
> > 83 adc->tx_buf |= ADS8344_CHANNEL(channel);
> > 84 adc->tx_buf |= ADS8344_CLOCK_INTERNAL;
> > 85
> > 86 ret = spi_write(spi, &adc->tx_buf, 1);
> > 87 if (ret)
> > 88 return ret;
> > 89
> > 90 udelay(9);
> > 91
> > 92 ret = spi_read(spi, buf, sizeof(buf));
> > 93 if (ret)
> > 94 return ret;
> > 95
> > > 96 return buf[0] << 9 | buf[1] << 1 | buf[2] >> 7;
> > 97 }
> > 98
> >
>
> I take it this is a false positive as I don't get any errors when
> building this driver with the provided toolchain. However, I see a few
> "internal compiler error: in priority, at haifa-sched.c:1599"
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
next prev parent reply other threads:[~2020-04-19 2:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 21:22 [PATCH 0/3] iio: adc: ti-ads8344: improve the driver Alexandre Belloni
2020-04-15 21:22 ` [PATCH 1/3] iio: adc: ti-ads8344: properly byte swap value Alexandre Belloni
2020-04-16 6:22 ` kbuild test robot
2020-04-16 20:50 ` Alexandre Belloni
2020-04-19 2:49 ` Philip Li [this message]
2020-04-21 7:25 ` Xia, Hui
2020-04-21 12:24 ` Alexandre Belloni
2020-04-16 6:29 ` Lars-Peter Clausen
2020-04-15 21:22 ` [PATCH 2/3] iio: adc: ti-ads8344: remove tx_buf from driver data Alexandre Belloni
2020-04-16 6:26 ` Lars-Peter Clausen
2020-04-17 10:24 ` Andy Shevchenko
2020-04-15 21:22 ` [PATCH 3/3] iio: adc: ti-ads8344: optimize consumption Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200419024948.GK21730@intel.com \
--to=philip.li@intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=gregory.clement@bootlin.com \
--cc=jic23@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).