* [PATCH] ARM: samsung: Omit superfluous error message in s3c_adc_probe()
@ 2020-04-19 7:05 Tang Bin
2020-04-21 9:38 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2020-04-19 7:05 UTC (permalink / raw)
To: kgene, krzk, linux
Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel, Tang Bin,
Shengju Zhang
In the function s3c_adc_probe(), when get irq failed,
the function platform_get_irq() logs an error message,
so remove redundant message here.
Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
arch/arm/plat-samsung/adc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/plat-samsung/adc.c b/arch/arm/plat-samsung/adc.c
index 4f7b27239..839bf7d5f 100644
--- a/arch/arm/plat-samsung/adc.c
+++ b/arch/arm/plat-samsung/adc.c
@@ -354,10 +354,8 @@ static int s3c_adc_probe(struct platform_device *pdev)
}
adc->irq = platform_get_irq(pdev, 1);
- if (adc->irq <= 0) {
- dev_err(dev, "failed to get adc irq\n");
+ if (adc->irq <= 0)
return -ENOENT;
- }
ret = devm_request_irq(dev, adc->irq, s3c_adc_irq, 0, dev_name(dev),
adc);
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: samsung: Omit superfluous error message in s3c_adc_probe()
2020-04-19 7:05 [PATCH] ARM: samsung: Omit superfluous error message in s3c_adc_probe() Tang Bin
@ 2020-04-21 9:38 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-04-21 9:38 UTC (permalink / raw)
To: Tang Bin
Cc: kgene, linux, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Shengju Zhang
On Sun, Apr 19, 2020 at 03:05:41PM +0800, Tang Bin wrote:
> In the function s3c_adc_probe(), when get irq failed,
> the function platform_get_irq() logs an error message,
> so remove redundant message here.
>
> Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> arch/arm/plat-samsung/adc.c | 4 +---
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-21 9:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-19 7:05 [PATCH] ARM: samsung: Omit superfluous error message in s3c_adc_probe() Tang Bin
2020-04-21 9:38 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).