From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Siddharth Gupta <sidgup@codeaurora.org>
Cc: agross@kernel.org, ohad@wizery.com,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tsoni@codeaurora.org,
psodagud@codeaurora.org, rishabhb@codeaurora.org
Subject: Re: [PATCH v2 3/6] remoteproc: sysmon: Inform current rproc about all active rprocs
Date: Mon, 20 Apr 2020 00:09:00 -0700 [thread overview]
Message-ID: <20200420070900.GF1868936@builder.lan> (raw)
In-Reply-To: <1586389003-26675-4-git-send-email-sidgup@codeaurora.org>
On Wed 08 Apr 16:36 PDT 2020, Siddharth Gupta wrote:
> Clients/services running on a remoteproc that booted up might need to be
> aware of the state of already running remoteprocs. When a remoteproc boots
> up (fresh or after recovery) it is not aware of the remoteprocs that booted
> before it, i.e., the system state is incomplete. So to keep track of it we
> send sysmon on behalf of all 'ONLINE' remoteprocs.
>
> Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/remoteproc/qcom_sysmon.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c
> index 851664e..8d8996d 100644
> --- a/drivers/remoteproc/qcom_sysmon.c
> +++ b/drivers/remoteproc/qcom_sysmon.c
> @@ -453,10 +453,20 @@ static int sysmon_prepare(struct rproc_subdev *subdev)
> return 0;
> }
>
> +/**
> + * sysmon_start() - start callback for the sysmon remoteproc subdevice
> + * @subdev: instance of the sysmon subdevice
> + *
> + * Inform all the listners of sysmon notifications that the rproc associated
> + * to @subdev has booted up. The rproc that booted up also needs to know
> + * which rprocs are already up and running, so send start notifications
> + * on behalf of all the online rprocs.
> + */
> static int sysmon_start(struct rproc_subdev *subdev)
> {
> struct qcom_sysmon *sysmon = container_of(subdev, struct qcom_sysmon,
> subdev);
> + struct qcom_sysmon *target;
> struct sysmon_event event = {
> .subsys_name = sysmon->name,
> .ssr_event = SSCTL_SSR_EVENT_AFTER_POWERUP
> @@ -464,6 +474,21 @@ static int sysmon_start(struct rproc_subdev *subdev)
>
> blocking_notifier_call_chain(&sysmon_notifiers, 0, (void *)&event);
>
> + mutex_lock(&sysmon_lock);
> + list_for_each_entry(target, &sysmon_list, node) {
> + if (target == sysmon ||
> + target->rproc->state != RPROC_RUNNING)
> + continue;
> +
> + event.subsys_name = target->name;
> +
> + if (sysmon->ssctl_version == 2)
> + ssctl_send_event(sysmon, &event);
> + else if (sysmon->ept)
> + sysmon_send_event(sysmon, &event);
> + }
> + mutex_unlock(&sysmon_lock);
> +
> return 0;
> }
>
> --
> Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-04-20 7:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 23:36 [PATCH v2 0/6] remoteproc: qcom: Add callbacks for remoteproc events Siddharth Gupta
2020-04-08 23:36 ` [PATCH v2 1/6] remoteproc: sysmon: Add ability to send type of notification Siddharth Gupta
2020-04-15 17:03 ` Mathieu Poirier
2020-04-20 7:05 ` Bjorn Andersson
2020-04-08 23:36 ` [PATCH v2 2/6] remoteproc: sysmon: Add notifications for events Siddharth Gupta
2020-04-15 17:03 ` Mathieu Poirier
2020-04-20 7:05 ` Bjorn Andersson
2020-04-08 23:36 ` [PATCH v2 3/6] remoteproc: sysmon: Inform current rproc about all active rprocs Siddharth Gupta
2020-04-15 17:16 ` Mathieu Poirier
2020-04-20 7:09 ` Bjorn Andersson [this message]
2020-04-08 23:36 ` [PATCH v2 4/6] remoteproc: qcom: Add name field for every subdevice Siddharth Gupta
2020-04-15 18:11 ` Mathieu Poirier
2020-04-23 0:54 ` Bjorn Andersson
2020-04-08 23:36 ` [PATCH v2 5/6] remoteproc: qcom: Add per subsystem SSR notification Siddharth Gupta
2020-04-15 18:07 ` Mathieu Poirier
2020-04-23 0:53 ` Bjorn Andersson
2020-04-08 23:36 ` [PATCH v2 6/6] remoteproc: qcom: Add notification types to SSR Siddharth Gupta
2020-04-15 18:10 ` Mathieu Poirier
2020-04-23 0:58 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420070900.GF1868936@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=psodagud@codeaurora.org \
--cc=rishabhb@codeaurora.org \
--cc=sidgup@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).