linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next v3 0/3] dt-bindings: net: mdio.yaml fixes
@ 2020-04-20 18:07 Florian Fainelli
  2020-04-20 18:07 ` [PATCH net-next v3 1/3] dt-bindings: net: Correct description of 'broken-turn-around' Florian Fainelli
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Florian Fainelli @ 2020-04-20 18:07 UTC (permalink / raw)
  To: netdev
  Cc: Florian Fainelli, Andrew Lunn, Heiner Kallweit, Russell King,
	David S. Miller, Rob Herring,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

Hi,

This patch series documents some common MDIO devices properties such as
resets (and delays) and broken-turn-around. The second patch also
rephrases some descriptions to be more general towards MDIO devices and
not specific towards Ethernet PHYs.

Changes in v3:

- corrected wording of 'broken-turn-around' in ethernet-phy.yaml and
  mdio.yaml, add Andrew's R-b tag to patch #3

Florian Fainelli (3):
  dt-bindings: net: Correct description of 'broken-turn-around'
  dt-bindings: net: mdio: Document common properties
  dt-bindings: net: mdio: Make descriptions more general

 .../devicetree/bindings/net/ethernet-phy.yaml |  3 +-
 .../devicetree/bindings/net/mdio.yaml         | 38 ++++++++++++++++---
 2 files changed, 35 insertions(+), 6 deletions(-)

-- 
2.19.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH net-next v3 1/3] dt-bindings: net: Correct description of 'broken-turn-around'
  2020-04-20 18:07 [PATCH net-next v3 0/3] dt-bindings: net: mdio.yaml fixes Florian Fainelli
@ 2020-04-20 18:07 ` Florian Fainelli
  2020-04-20 19:58   ` Andrew Lunn
  2020-04-20 18:07 ` [PATCH net-next v3 2/3] dt-bindings: net: mdio: Document common properties Florian Fainelli
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: Florian Fainelli @ 2020-04-20 18:07 UTC (permalink / raw)
  To: netdev
  Cc: Florian Fainelli, Andrew Lunn, Heiner Kallweit, Russell King,
	David S. Miller, Rob Herring,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

The turn around bytes (2) are placed between the control phase of the
MDIO transaction and the data phase, correct the wording to be more
exact.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 Documentation/devicetree/bindings/net/ethernet-phy.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
index 5aa141ccc113..9b1f1147ca36 100644
--- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
@@ -81,7 +81,8 @@ properties:
     $ref: /schemas/types.yaml#definitions/flag
     description:
       If set, indicates the PHY device does not correctly release
-      the turn around line low at the end of a MDIO transaction.
+      the turn around line low at end of the control phase of the
+      MDIO transaction.
 
   enet-phy-lane-swap:
     $ref: /schemas/types.yaml#definitions/flag
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH net-next v3 2/3] dt-bindings: net: mdio: Document common properties
  2020-04-20 18:07 [PATCH net-next v3 0/3] dt-bindings: net: mdio.yaml fixes Florian Fainelli
  2020-04-20 18:07 ` [PATCH net-next v3 1/3] dt-bindings: net: Correct description of 'broken-turn-around' Florian Fainelli
@ 2020-04-20 18:07 ` Florian Fainelli
  2020-04-20 19:59   ` Andrew Lunn
  2020-04-20 18:07 ` [PATCH net-next v3 3/3] dt-bindings: net: mdio: Make descriptions more general Florian Fainelli
  2020-04-22 18:43 ` [PATCH net-next v3 0/3] dt-bindings: net: mdio.yaml fixes David Miller
  3 siblings, 1 reply; 7+ messages in thread
From: Florian Fainelli @ 2020-04-20 18:07 UTC (permalink / raw)
  To: netdev
  Cc: Florian Fainelli, Andrew Lunn, Heiner Kallweit, Russell King,
	David S. Miller, Rob Herring,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

Some of the properties pertaining to the broken turn around or resets
were only documented in ethernet-phy.yaml while they are applicable
across all MDIO devices and not Ethernet PHYs specifically which are a
superset.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 .../devicetree/bindings/net/mdio.yaml         | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/mdio.yaml b/Documentation/devicetree/bindings/net/mdio.yaml
index 50c3397a82bc..9efb7d623f0e 100644
--- a/Documentation/devicetree/bindings/net/mdio.yaml
+++ b/Documentation/devicetree/bindings/net/mdio.yaml
@@ -50,6 +50,34 @@ patternProperties:
         description:
           The ID number for the PHY.
 
+      broken-turn-around:
+        $ref: /schemas/types.yaml#definitions/flag
+        description:
+          If set, indicates the MDIO device does not correctly release
+          the turn around line low at end of the control phase of the
+          MDIO transaction.
+
+      resets:
+        maxItems: 1
+
+      reset-names:
+        const: phy
+
+      reset-gpios:
+        maxItems: 1
+        description:
+          The GPIO phandle and specifier for the MDIO reset signal.
+
+      reset-assert-us:
+        description:
+          Delay after the reset was asserted in microseconds. If this
+          property is missing the delay will be skipped.
+
+      reset-deassert-us:
+        description:
+          Delay after the reset was deasserted in microseconds. If
+          this property is missing the delay will be skipped.
+
     required:
       - reg
 
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH net-next v3 3/3] dt-bindings: net: mdio: Make descriptions more general
  2020-04-20 18:07 [PATCH net-next v3 0/3] dt-bindings: net: mdio.yaml fixes Florian Fainelli
  2020-04-20 18:07 ` [PATCH net-next v3 1/3] dt-bindings: net: Correct description of 'broken-turn-around' Florian Fainelli
  2020-04-20 18:07 ` [PATCH net-next v3 2/3] dt-bindings: net: mdio: Document common properties Florian Fainelli
@ 2020-04-20 18:07 ` Florian Fainelli
  2020-04-22 18:43 ` [PATCH net-next v3 0/3] dt-bindings: net: mdio.yaml fixes David Miller
  3 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2020-04-20 18:07 UTC (permalink / raw)
  To: netdev
  Cc: Florian Fainelli, Andrew Lunn, Heiner Kallweit, Russell King,
	David S. Miller, Rob Herring,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

A number of descriptions assume a PHY device, but since this binding
describes a MDIO bus which can have different kinds of MDIO devices
attached to it, rephrase some descriptions to be more general in that
regard.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 Documentation/devicetree/bindings/net/mdio.yaml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/mdio.yaml b/Documentation/devicetree/bindings/net/mdio.yaml
index 9efb7d623f0e..d83fe5980fb8 100644
--- a/Documentation/devicetree/bindings/net/mdio.yaml
+++ b/Documentation/devicetree/bindings/net/mdio.yaml
@@ -31,13 +31,13 @@ properties:
     maxItems: 1
     description:
       The phandle and specifier for the GPIO that controls the RESET
-      lines of all PHYs on that MDIO bus.
+      lines of all devices on that MDIO bus.
 
   reset-delay-us:
     description:
-      RESET pulse width in microseconds. It applies to all PHY devices
-      and must therefore be appropriately determined based on all PHY
-      requirements (maximum value of all per-PHY RESET pulse widths).
+      RESET pulse width in microseconds. It applies to all MDIO devices
+      and must therefore be appropriately determined based on all devices
+      requirements (maximum value of all per-device RESET pulse widths).
 
 patternProperties:
   "^ethernet-phy@[0-9a-f]+$":
@@ -48,7 +48,7 @@ patternProperties:
         minimum: 0
         maximum: 31
         description:
-          The ID number for the PHY.
+          The ID number for the device.
 
       broken-turn-around:
         $ref: /schemas/types.yaml#definitions/flag
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH net-next v3 1/3] dt-bindings: net: Correct description of 'broken-turn-around'
  2020-04-20 18:07 ` [PATCH net-next v3 1/3] dt-bindings: net: Correct description of 'broken-turn-around' Florian Fainelli
@ 2020-04-20 19:58   ` Andrew Lunn
  0 siblings, 0 replies; 7+ messages in thread
From: Andrew Lunn @ 2020-04-20 19:58 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: netdev, Heiner Kallweit, Russell King, David S. Miller,
	Rob Herring,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

On Mon, Apr 20, 2020 at 11:07:21AM -0700, Florian Fainelli wrote:
> The turn around bytes (2) are placed between the control phase of the
> MDIO transaction and the data phase, correct the wording to be more
> exact.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH net-next v3 2/3] dt-bindings: net: mdio: Document common properties
  2020-04-20 18:07 ` [PATCH net-next v3 2/3] dt-bindings: net: mdio: Document common properties Florian Fainelli
@ 2020-04-20 19:59   ` Andrew Lunn
  0 siblings, 0 replies; 7+ messages in thread
From: Andrew Lunn @ 2020-04-20 19:59 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: netdev, Heiner Kallweit, Russell King, David S. Miller,
	Rob Herring,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

On Mon, Apr 20, 2020 at 11:07:22AM -0700, Florian Fainelli wrote:
> Some of the properties pertaining to the broken turn around or resets
> were only documented in ethernet-phy.yaml while they are applicable
> across all MDIO devices and not Ethernet PHYs specifically which are a
> superset.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH net-next v3 0/3] dt-bindings: net: mdio.yaml fixes
  2020-04-20 18:07 [PATCH net-next v3 0/3] dt-bindings: net: mdio.yaml fixes Florian Fainelli
                   ` (2 preceding siblings ...)
  2020-04-20 18:07 ` [PATCH net-next v3 3/3] dt-bindings: net: mdio: Make descriptions more general Florian Fainelli
@ 2020-04-22 18:43 ` David Miller
  3 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2020-04-22 18:43 UTC (permalink / raw)
  To: f.fainelli
  Cc: netdev, andrew, hkallweit1, linux, robh+dt, devicetree, linux-kernel

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 20 Apr 2020 11:07:20 -0700

> This patch series documents some common MDIO devices properties such as
> resets (and delays) and broken-turn-around. The second patch also
> rephrases some descriptions to be more general towards MDIO devices and
> not specific towards Ethernet PHYs.
> 
> Changes in v3:
> 
> - corrected wording of 'broken-turn-around' in ethernet-phy.yaml and
>   mdio.yaml, add Andrew's R-b tag to patch #3

Series applied, thanks Florian.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-04-22 18:43 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 18:07 [PATCH net-next v3 0/3] dt-bindings: net: mdio.yaml fixes Florian Fainelli
2020-04-20 18:07 ` [PATCH net-next v3 1/3] dt-bindings: net: Correct description of 'broken-turn-around' Florian Fainelli
2020-04-20 19:58   ` Andrew Lunn
2020-04-20 18:07 ` [PATCH net-next v3 2/3] dt-bindings: net: mdio: Document common properties Florian Fainelli
2020-04-20 19:59   ` Andrew Lunn
2020-04-20 18:07 ` [PATCH net-next v3 3/3] dt-bindings: net: mdio: Make descriptions more general Florian Fainelli
2020-04-22 18:43 ` [PATCH net-next v3 0/3] dt-bindings: net: mdio.yaml fixes David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).