* [PATCH] net: bpf: Allow TC programs to call BPF_FUNC_skb_change_head
@ 2020-04-20 18:34 Maciej Żenczykowski
2020-04-26 16:02 ` Alexei Starovoitov
0 siblings, 1 reply; 2+ messages in thread
From: Maciej Żenczykowski @ 2020-04-20 18:34 UTC (permalink / raw)
To: Maciej Żenczykowski, Alexei Starovoitov, Daniel Borkmann
Cc: Linux Network Development Mailing List, linux-kernel,
David S . Miller, Lorenzo Colitti
From: Lorenzo Colitti <lorenzo@google.com>
This allows TC eBPF programs to modify and forward (redirect) packets
from interfaces without ethernet headers (for example cellular)
to interfaces with (for example ethernet/wifi).
The lack of this appears to simply be an oversight.
Tested:
in active use in Android R on 4.14+ devices for ipv6
cellular to wifi tethering offload.
Signed-off-by: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
net/core/filter.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/core/filter.c b/net/core/filter.c
index 7d6ceaa54d21..755867867e57 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -6213,6 +6213,8 @@ tc_cls_act_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
return &bpf_skb_adjust_room_proto;
case BPF_FUNC_skb_change_tail:
return &bpf_skb_change_tail_proto;
+ case BPF_FUNC_skb_change_head:
+ return &bpf_skb_change_head_proto;
case BPF_FUNC_skb_get_tunnel_key:
return &bpf_skb_get_tunnel_key_proto;
case BPF_FUNC_skb_set_tunnel_key:
--
2.26.1.301.g55bc3eb7cb9-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: bpf: Allow TC programs to call BPF_FUNC_skb_change_head
2020-04-20 18:34 [PATCH] net: bpf: Allow TC programs to call BPF_FUNC_skb_change_head Maciej Żenczykowski
@ 2020-04-26 16:02 ` Alexei Starovoitov
0 siblings, 0 replies; 2+ messages in thread
From: Alexei Starovoitov @ 2020-04-26 16:02 UTC (permalink / raw)
To: Maciej Żenczykowski
Cc: Maciej Żenczykowski, Alexei Starovoitov, Daniel Borkmann,
Linux Network Development Mailing List, LKML, David S . Miller,
Lorenzo Colitti
On Mon, Apr 20, 2020 at 11:34 AM Maciej Żenczykowski
<zenczykowski@gmail.com> wrote:
>
> From: Lorenzo Colitti <lorenzo@google.com>
>
> This allows TC eBPF programs to modify and forward (redirect) packets
> from interfaces without ethernet headers (for example cellular)
> to interfaces with (for example ethernet/wifi).
>
> The lack of this appears to simply be an oversight.
>
> Tested:
> in active use in Android R on 4.14+ devices for ipv6
> cellular to wifi tethering offload.
>
> Signed-off-by: Lorenzo Colitti <lorenzo@google.com>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
Applied. Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-26 16:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 18:34 [PATCH] net: bpf: Allow TC programs to call BPF_FUNC_skb_change_head Maciej Żenczykowski
2020-04-26 16:02 ` Alexei Starovoitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).