From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Masahiro Yamada <masahiroy@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [GIT pull] perf/urgent for 5.7-rc2
Date: Mon, 20 Apr 2020 21:17:28 +0200 [thread overview]
Message-ID: <20200420191728.GN20730@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200420181730.4bmggezf2zhu4ffb@treble>
On Mon, Apr 20, 2020 at 01:17:30PM -0500, Josh Poimboeuf wrote:
> On Mon, Apr 20, 2020 at 07:40:31PM +0200, Peter Zijlstra wrote:
> > So my pet peeve is that when objtool errors, or crashes, the .o file
> > gets deleted and it becomes really hard to debug the situation. I'm
> > thinking that your suggestion would actually help with that too.
>
> I do have the same pet peeve and I'm thinking we should just revert
> 644592d32837 ("objtool: Fail the kernel build on fatal errors") which
> would ease most of the pain. Those fatal errors don't really buy us
> much IMO. Agree?
Well, I like that it stops the kernel build on an error; I hate that it
makes it so damn hard to then diagnose and fix the error :/
Also, it doesn't really help for crashes, luckily those are somewhat
rare -- except I had one today as a result of a mis-merge...
> > I just don't have enough Kbuild foo to even attempt this :/
>
> It's an interesting idea, but it might have its own share of annoyances.
>
> If you added something bad to a file, and just rebuilt that file, you
> wouldn't see the objtool warning until later when you build the entire
> kernel.
Moo.. :/
next prev parent reply other threads:[~2020-04-20 19:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 13:56 [GIT pull] core/urgent for 5.7-rc2 Thomas Gleixner
2020-04-19 13:56 ` [GIT pull] irq/urgent " Thomas Gleixner
2020-04-19 19:20 ` pr-tracker-bot
2020-04-19 13:56 ` [GIT pull] perf/urgent " Thomas Gleixner
2020-04-19 18:56 ` Linus Torvalds
2020-04-19 20:07 ` Josh Poimboeuf
2020-04-20 7:48 ` Ingo Molnar
2020-04-20 8:27 ` Peter Zijlstra
2020-04-22 7:45 ` Ingo Molnar
2020-04-22 11:56 ` Peter Zijlstra
2020-04-20 16:51 ` Linus Torvalds
2020-04-20 17:40 ` Peter Zijlstra
2020-04-20 18:17 ` Josh Poimboeuf
2020-04-20 19:17 ` Peter Zijlstra [this message]
2020-04-20 19:21 ` Linus Torvalds
2020-04-20 19:36 ` Josh Poimboeuf
2020-04-19 19:20 ` pr-tracker-bot
2020-04-19 13:56 ` [GIT pull] sched/urgent " Thomas Gleixner
2020-04-19 19:20 ` pr-tracker-bot
2020-04-19 13:56 ` [GIT pull] timers/urgent " Thomas Gleixner
2020-04-19 19:20 ` pr-tracker-bot
2020-04-19 13:56 ` [GIT pull] x86/urgent " Thomas Gleixner
2020-04-19 19:20 ` pr-tracker-bot
2020-04-19 19:20 ` [GIT pull] core/urgent " pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420191728.GN20730@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).