From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8030C54FC9 for ; Tue, 21 Apr 2020 06:08:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C50DF2076C for ; Tue, 21 Apr 2020 06:08:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ULcRFem5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726626AbgDUGIo (ORCPT ); Tue, 21 Apr 2020 02:08:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725901AbgDUGIn (ORCPT ); Tue, 21 Apr 2020 02:08:43 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7618C061A0F for ; Mon, 20 Apr 2020 23:08:41 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id p25so6137816pfn.11 for ; Mon, 20 Apr 2020 23:08:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sDllzFsBHZPyzu3AXJKIrXB/1lUAjyHJuSQk9xHlHNQ=; b=ULcRFem5v+TtwwUxzAUUNG7yK13oeDuKqJl6RdKJCP9R+zDZCr/nW2iHIEDS8zEdEm CxyQiXeOA0o3Rq2Kx9kuS8YKt/0aGF+AEllryuRIJ8d9F/9JAhIl3MkYe9N+7o48UgpW E4ADuUERsn7TuLm9656ZnEC8GTcgxudT8/pM05cQoe8FD0QF9Ao4g3beZdEeTsWT0qgv 8IjiutyJrOz5C4BVLcJUq4SFE/V7JBSi/E858GmurNXE0YSU8/37CWRreVO8lWbSLUYv yuBMA5MIGC4Iq3zaEI7dwllei5NoyR2ySjfhYTdaxmWsxXEj52ovTz7mCBa1JC8F4FVX qN6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sDllzFsBHZPyzu3AXJKIrXB/1lUAjyHJuSQk9xHlHNQ=; b=QPDIk6LugxcsNRoLzgFwUw1FaltOxIKUfi4hvGnCKef+JUssWLhWNUrxDVo3FMrtvx om/uHiMKuw/YqMZBmlUoKGIm8XE5qbTJ94wjzrlCbNQYcXn+R6ENtACk20UMEAqHtoI4 WG4UTQ2rPcgUjqlHkF5S29h5jh6ATEsaMAtKphj3siEzQZK35QJwlDnnbTP1E5ROpVwq +mkAlGGWy5S8cl4Fl3y/ZLIwr/vtGD9bytlkwlY9hrh6aC+a7az8tVIr5b/n8ROE0H8U ZXDLgjnX2baAiz5rWtav2AVIAJWbO2AXZk7VBUfSwiYXtt9wdFzsbr+DJ77oKOvYXA/J Ibng== X-Gm-Message-State: AGi0Pua1YtLZv/ZTJWzRA/o+2RqgUL3iwPN9QuQ9/Qq+HeytgpNMDH6a 3GY2YlzBeMjENNHsYkuHaM0x X-Google-Smtp-Source: APiQypJvUWR+vtt1MwPMwz9EAnmfbaVX7c3szY5KnMLNgLD/6RlREpPcv7pnpkkvTZIWlRJ4XS35HA== X-Received: by 2002:a62:7656:: with SMTP id r83mr19972450pfc.71.1587449321441; Mon, 20 Apr 2020 23:08:41 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:6289:7463:c15b:2de1:b77e:d971]) by smtp.gmail.com with ESMTPSA id p189sm1367714pfp.135.2020.04.20.23.08.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Apr 2020 23:08:40 -0700 (PDT) Date: Tue, 21 Apr 2020 11:38:35 +0530 From: Manivannan Sadhasivam To: Jeffrey Hugo , Bhaumik Vasav Bhatt , Hemant Kumar Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] bus: mhi: core: Handle syserr during power_up Message-ID: <20200421060835.GD4327@Mani-XPS-13-9360> References: <1586278230-29565-1-git-send-email-jhugo@codeaurora.org> <1586278230-29565-2-git-send-email-jhugo@codeaurora.org> <1768ba6e-12c2-7b4f-0f17-44fecc6473b9@codeaurora.org> <11d9f35b-b911-7985-8846-0a45904ceed1@codeaurora.org> <5c4efe13-42a4-e802-4070-5d9d30b8cac2@codeaurora.org> <79feeb0b-0837-c5b6-087d-856c3e238c67@codeaurora.org> <20200413133447.GA19124@Mani-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2020 at 08:01:36AM -0600, Jeffrey Hugo wrote: > On 4/13/2020 7:34 AM, Manivannan Sadhasivam wrote: > > On Fri, Apr 10, 2020 at 03:39:57PM -0600, Jeffrey Hugo wrote: > > > On 4/10/2020 2:37 PM, Bhaumik Vasav Bhatt wrote: > > > > Hi Jeff, > > > > > > > > We will always have the mhi_intvec_handler registered and trigger your > > > > wake_up state event when you write MHI RESET. BHI INTVEC IRQ using > > > > mhi_cntrl->irq[0] is _not_ unregistered once you enter AMSS EE. > > > > > > I understand it is not unregistered. However mhi_cntrl->irq[0] may be > > > reserved for BHI, and thus only exercised by PBL EE. Where as, > > > mhi_cntrl->irq[1..N] may be only exercised by AMSS EE. mhi_intvec_handler is > > > not called in response to mhi_cntrl->irq[1..N]. > > > > > > Additionally, I re-reviewed the MHI spec, and I don't see where the spec > > > requires the device to issue an interrupt upon completion of the RESET > > > request. > > > > > > Under section 3.5, step 11 states - > > > > > > "The host must poll for the value of the RESET bit to detect the completion > > > of the reset procedure by the device (RESET is set to 0)." > > > > > > > If this is the scenario then we need to change all of the wait_event_timeout() > > implementation for MHI RESET in current stack to polling. > > > > Or the interrupt generation is not defined in spec (sheet) but part of the > > existing implementation? > > It probably could be considered part of the existing implementation, but I'd > like to hear from Hemant/Bhaumik. Wherever we end up, I'd like to have the > spec match. Hemant/Bhaumik, can you please share your thoughts? Thanks, Mani > > -- > Jeffrey Hugo > Qualcomm Technologies, Inc. is a member of the > Code Aurora Forum, a Linux Foundation Collaborative Project.