linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: Tony Lindgren <tony@atomide.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
	Lee Jones <lee.jones@linaro.org>, Jiri Slaby <jslaby@suse.cz>,
	Johan Hovold <johan@kernel.org>,
	Merlijn Wajer <merlijn@wizzup.org>,
	Peter Hurley <peter@hurleysoftware.com>,
	Sebastian Reichel <sre@kernel.org>,
	linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/4] serdev: ngsm-motmdm: Add Motorola TS 27.010 serdev modem driver for droid4
Date: Tue, 21 Apr 2020 10:28:40 +0200	[thread overview]
Message-ID: <20200421082840.GA4540@amd> (raw)
In-Reply-To: <20200319173755.65082-3-tony@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 2284 bytes --]

Hi!

> $ printf "ATH\r" > /dev/motmdm1
> H:OK
> 
> Also SMS can be sent with this patch using /dev/motmdm3 for sending,
> and /dev/motmdm9 for receiving messages, and /dev/motmdm10 can be
> used for SIM access.
> 
> Note that the audio mixer needs additional patches though. I will be
> sending those as a separate series of patches.
> 
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Reviewed-by: Pavel Machek <pavel@ucw.cz>

Some minor comments are below.

> +++ b/drivers/tty/serdev/protocol/Kconfig
> @@ -0,0 +1,14 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Serial bus device driver protocol specific configuration
> +#
> +
> +config SERIAL_DEV_NGSM_MOTMDM
> +	tristate "Motorola Modem TS 27.010 Serdev Protocol Driver"
> +	depends on N_GSM && PHY_MAPPHONE_MDM6600
> +	help
> +	  Select this for Motorola modems using TS 27.010 serial line
> +	  discipline such as MDM6600 modem found on Motorola Mapphone
> +	  devices like Droid4

I'd add "." at the end of sentence.

> +/*
> + * Character devices for DLCI channels with no serdev drivers
> + */
> +static int motmdm_cdev_open(struct inode *inode, struct file *file)
> +{
> +	struct motmdm_cdev *cdata;
> +	int ret = 0;
> +
> +	cdata = container_of(inode->i_cdev, struct motmdm_cdev, cdev);
> +	get_device(cdata->dev);
> +	nonseekable_open(inode, file);
> +	file->private_data = cdata;
> +
> +	down_write(&cdata->rwsem);
> +	if (cdata->disconnected) {
> +		ret = -ENODEV;
> +		goto unlock;
> +	}
> +
> +unlock:
> +	up_write(&cdata->rwsem);

You can delete goto and the label here.

> +static int motmdm_cdev_release(struct inode *inode, struct file *file)
> +{
> +	struct motmdm_cdev *cdata = file->private_data;
> +
> +	down_write(&cdata->rwsem);
> +	if (cdata->disconnected)
> +		goto unlock;
> +
> +unlock:
> +	up_write(&cdata->rwsem);

And here... unless it is some kind of preparation for next patch?

> +MODULE_DESCRIPTION("Motorola Modem TS 27.010 serdev driver");
> +MODULE_AUTHOR("Tony Lindgren <tony@atomide.com");

Missing ">" at the end of email address.

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2020-04-21  8:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19 17:37 [PATCHv5 0/4] n_gsm serdev support and protocol driver for droid4 modem Tony Lindgren
2020-03-19 17:37 ` [PATCH 1/4] tty: n_gsm: Add support for serdev drivers Tony Lindgren
2020-03-22 22:42   ` Droid 4 in -next -- still no backlight was " Pavel Machek
2020-03-24 17:01     ` Tony Lindgren
2020-03-24 17:36       ` Tony Lindgren
2020-04-20 21:55   ` Pavel Machek
2020-03-19 17:37 ` [PATCH 2/4] serdev: ngsm-motmdm: Add Motorola TS 27.010 serdev modem driver for droid4 Tony Lindgren
2020-03-22 22:09   ` Pavel Machek
2020-03-24 16:34     ` Tony Lindgren
2020-04-21  8:28   ` Pavel Machek [this message]
2020-03-19 17:37 ` [PATCH 3/4] dt-bindings: mfd: motmdm: Add binding for motorola-mdm Tony Lindgren
2020-03-24 11:58   ` Lee Jones
2020-03-24 16:37     ` Tony Lindgren
2020-03-19 17:37 ` [PATCH 4/4] ARM: dts: omap4-droid4: Enable basic modem support Tony Lindgren
2020-04-21  8:31   ` Pavel Machek
2020-04-21 11:59 ` [PATCHv5 0/4] n_gsm serdev support and protocol driver for droid4 modem Pavel Machek
2020-04-21 12:48   ` Greg Kroah-Hartman
2020-04-21 14:09     ` Tony Lindgren
2020-04-21 20:39     ` Pavel Machek
2020-04-21 23:27 [PATCHv6 " Tony Lindgren
2020-04-21 23:27 ` [PATCH 2/4] serdev: ngsm-motmdm: Add Motorola TS 27.010 serdev modem driver for droid4 Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200421082840.GA4540@amd \
    --to=pavel@denx.de \
    --cc=devicetree@vger.kernel.org \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=jslaby@suse.cz \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=merlijn@wizzup.org \
    --cc=peter@hurleysoftware.com \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    --subject='Re: [PATCH 2/4] serdev: ngsm-motmdm: Add Motorola TS 27.010 serdev modem driver for droid4' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).