From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF69C54FC9 for ; Tue, 21 Apr 2020 10:50:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1232206A5 for ; Tue, 21 Apr 2020 10:50:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728642AbgDUKuw (ORCPT ); Tue, 21 Apr 2020 06:50:52 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:53427 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728479AbgDUKuw (ORCPT ); Tue, 21 Apr 2020 06:50:52 -0400 Received: from ip5f5af183.dynamic.kabel-deutschland.de ([95.90.241.131] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jQqU1-0003mW-0u; Tue, 21 Apr 2020 10:50:29 +0000 Date: Tue, 21 Apr 2020 12:50:28 +0200 From: Christian Brauner To: Oleg Nesterov Cc: "Eric W. Biederman" , Linux Containers , Christof Meerwald , linux-kernel@vger.kernel.org Subject: Re: [PATCH] remove the no longer needed pid_alive() check in __task_pid_nr_ns() Message-ID: <20200421105028.fihn4kczt6pqzfdr@wittgenstein> References: <20200419201336.GI22017@edge.cmeerw.net> <87sggyytnh.fsf@x220.int.ebiederm.org> <20200421090426.GA6787@redhat.com> <20200421101904.GA9358@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200421101904.GA9358@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2020 at 12:19:04PM +0200, Oleg Nesterov wrote: > Starting from 2c4704756cab ("pids: Move the pgrp and session pid pointers > from task_struct to signal_struct") __task_pid_nr_ns() doesn't dereference > task->group_leader, we can remove the pid_alive() check. > > pid_nr_ns() has to check pid != NULL anyway, pid_alive() just adds the > unnecessary confusion. > > Signed-off-by: Oleg Nesterov > --- Acked-by: Christian Brauner