From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: mkl@pengutronix.de, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
kernel@pengutronix.de, netdev <netdev@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
David Jander <david@protonic.nl>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: dsa: sja1105: regression after patch: "net: dsa: configure the MTU for switch ports"
Date: Tue, 21 Apr 2020 14:58:28 +0200 [thread overview]
Message-ID: <20200421125828.jb44qzfzgd7sh436@pengutronix.de> (raw)
In-Reply-To: <CA+h21ho2YnUfzMja1Y7=B7Yrqk=WD6jm-OoKKzX4uS3WJiU5aw@mail.gmail.com>
On Tue, Apr 21, 2020 at 02:56:37PM +0300, Vladimir Oltean wrote:
> Hi Oleksij,
>
> On Tue, 21 Apr 2020 at 14:33, Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> >
> > Hi Vladimir,
> >
> > I have a regression after this patch:
> > |commit bfcb813203e619a8960a819bf533ad2a108d8105
> > |Author: Vladimir Oltean <vladimir.oltean@nxp.com>
> > |
> > | net: dsa: configure the MTU for switch ports
> >
> > with following log:
> > [ 3.044065] sja1105 spi1.0: Probed switch chip: SJA1105Q
> > [ 3.071385] sja1105 spi1.0: Enabled switch tagging
> > [ 3.076484] sja1105 spi1.0: error -34 setting MTU on port 0
> > [ 3.082795] sja1105: probe of spi1.0 failed with error -34
> >
> > this is devicetree snippet for the port 0:
> > port@0 {
> > reg = <0>;
> > label = "usb";
> > phy-handle = <&usbeth_phy>;
> > phy-mode = "rmii";
> > };
> >
> >
> > Is it know issue?
> >
> The code which is causing problems seems to be this one:
>
> mtu_limit = min_t(int, master->max_mtu, dev->max_mtu);
> old_master_mtu = master->mtu;
> new_master_mtu = largest_mtu + cpu_dp->tag_ops->overhead;
> if (new_master_mtu > mtu_limit)
> return -ERANGE;
>
> called from
>
> rtnl_lock();
> ret = dsa_slave_change_mtu(slave_dev, ETH_DATA_LEN);
> rtnl_unlock();
> if (ret && ret != -EOPNOTSUPP) {
> dev_err(ds->dev, "error %d setting MTU on port %d\n",
> ret, port->index);
> goto out_free;
> }
>
> Before this patch, it was silently failing, now it's preventing the
> probing of the ports which I might agree with you is not better.
> Andrew warned about this, and I guess that during probe, we should
> warn but ignore any nonzero return code, not just EOPNOTSUPP. I'll
> send a patch out shortly to correct this.
>
> Out of curiosity, what DSA master port do you have? Does it not
> support an MTU of 1504 bytes? Does MTU-sized traffic pass correctly
> through your interface? (you can test with iperf3)
It is FEC@iMX6QP attached to the port 4 of the sja1105 switch.
I'll try to make some tests tomorrow.
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2020-04-21 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 11:33 dsa: sja1105: regression after patch: "net: dsa: configure the MTU for switch ports" Oleksij Rempel
2020-04-21 11:56 ` Vladimir Oltean
2020-04-21 12:58 ` Oleksij Rempel [this message]
2020-04-21 13:27 ` Andrew Lunn
2020-04-21 13:35 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421125828.jb44qzfzgd7sh436@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).