From: kbuild test robot <lkp@intel.com>
To: Hui Song <hui.song_1@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Cc: kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] gpio: mpc8xxx: Add shutdown function.
Date: Tue, 21 Apr 2020 13:44:41 +0800 [thread overview]
Message-ID: <202004211315.zr8Yc1wJ%lkp@intel.com> (raw)
In-Reply-To: <20200409090259.13126-1-hui.song_1@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 2355 bytes --]
Hi Hui,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on gpio/for-next]
[also build test ERROR on v5.7-rc2 next-20200420]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Hui-Song/gpio-mpc8xxx-Add-shutdown-function/20200410-000846
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpio/gpio-mpc8xxx.c:463:14: error: initialization of 'void (*)(struct platform_device *)' from incompatible pointer type 'int (*)(struct platform_device *)' [-Werror=incompatible-pointer-types]
463 | .shutdown = mpc8xxx_shutdown,
| ^~~~~~~~~~~~~~~~
drivers/gpio/gpio-mpc8xxx.c:463:14: note: (near initialization for 'mpc8xxx_plat_driver.shutdown')
cc1: some warnings being treated as errors
vim +463 drivers/gpio/gpio-mpc8xxx.c
448
449 static int mpc8xxx_shutdown(struct platform_device *pdev)
450 {
451 struct mpc8xxx_gpio_chip *mpc8xxx_gc = platform_get_drvdata(pdev);
452
453 if (mpc8xxx_gc->irq) {
454 irq_set_chained_handler_and_data(mpc8xxx_gc->irqn, NULL, NULL);
455 irq_domain_remove(mpc8xxx_gc->irq);
456 }
457
458 return 0;
459 }
460 static struct platform_driver mpc8xxx_plat_driver = {
461 .probe = mpc8xxx_probe,
462 .remove = mpc8xxx_remove,
> 463 .shutdown = mpc8xxx_shutdown,
464 .driver = {
465 .name = "gpio-mpc8xxx",
466 .of_match_table = mpc8xxx_gpio_ids,
467 },
468 };
469
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48226 bytes --]
next prev parent reply other threads:[~2020-04-21 5:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 9:02 [PATCH] gpio: mpc8xxx: Add shutdown function Hui Song
2020-04-09 9:37 ` Russell King - ARM Linux admin
2020-04-21 5:44 ` kbuild test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-09 8:49 Hui Song
2020-04-08 10:21 [PATCH v1] " Hui Song
2020-04-08 10:21 ` [PATCH] " Hui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202004211315.zr8Yc1wJ%lkp@intel.com \
--to=lkp@intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hui.song_1@nxp.com \
--cc=kbuild-all@lists.01.org \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).